mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	mingo@elte.hu, rnalumasu@gmail.com
Subject: Re: + do_wait-wakeup-optimization.patch added to -mm tree
Date: Thu,  4 Dec 2008 12:59:42 -0800 (PST)	[thread overview]
Message-ID: <20081204205942.81079FC32C@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Thursday, 4 December 2008 16:26:01 +0100 <20081204152601.GB8816@redhat.com>

> > I don't see an exposed __wake_up* variant that both passes a "key" pointer
> > through and does "sync".  For __wake_up_parent, "sync" is quite desireable.
> 
> Well, yes... and __wake_up_common() is static. Perhaps we can make a new
> helper. 

Right, that's what I was suggesting (and not volunteering to do ;-).

> I must admit, I don't understand what "sync" actually means nowadays.

I don't claim to know any actual scheduler innards.  But the meaning as I
understand it is to "make it runnable, but don't try to reschedule right
now because current will block quite soon anyway.  If this does indeed
reduce work done to immediately reschedule, then it seems quite desireable
to avoid that flutter since the dying/stopping thread is very few cycles
away from yielding, and in the death case it will be for the last time and
rescheduling earlier just means a later unnecessary switch back and delayed
put_task_struct processing after the reap.


Thanks,
Roland


  reply	other threads:[~2008-12-04 21:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200811212015.mALKFMs4019558@imap1.linux-foundation.org>
2008-11-23 21:39 ` Oleg Nesterov
2008-11-23 21:55   ` do_wait() vs do_notify_parent_cldstop() theoretical race? Oleg Nesterov
2008-11-24  7:31     ` Roland McGrath
2008-12-04  1:05     ` Roland McGrath
2008-11-24  7:26   ` + do_wait-wakeup-optimization.patch added to -mm tree Roland McGrath
2008-12-04 15:26     ` Oleg Nesterov
2008-12-04 20:59       ` Roland McGrath [this message]
2008-12-04  1:06   ` Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081204205942.81079FC32C@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=oleg@redhat.com \
    --cc=rnalumasu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®