From: Ingo Molnar <mingo@elte.hu>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] tracing/ftrace: don't insert TRACE_PRINT during selftests
Date: Fri, 5 Dec 2008 14:48:18 +0100 [thread overview]
Message-ID: <20081205134818.GA27039@elte.hu> (raw)
In-Reply-To: <49385E07.7050304@gmail.com>
* Frederic Weisbecker <fweisbec@gmail.com> wrote:
> Impact: fix tracer selfstests false results
>
> After setting a ftrace_printk somewhere in th kernel, I saw the
> Function tracer selftest failing.
>
> When a selftest occurs, the ring buffer is lurked to see if
> some entries were inserted. But concurrent insertion such as
> ftrace_printk could occured at the same time and could give
> false positive or negative results.
>
> This patch prevent prevent from TRACE_PRINT entries insertion
> during selftests.
>
> Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
> ---
> kernel/trace/trace.c | 13 ++++++++++++-
> 1 files changed, 12 insertions(+), 1 deletions(-)
applied to tip/tracing/ftrace, thanks.
I suspect you'll also fix the things Steve pointed out?
Ingo
next prev parent reply other threads:[~2008-12-05 13:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 22:47 Frederic Weisbecker
2008-12-04 22:55 ` Steven Rostedt
2008-12-04 23:03 ` Frédéric Weisbecker
2008-12-04 23:04 ` Frédéric Weisbecker
2008-12-04 23:26 ` Steven Rostedt
2008-12-05 13:48 ` Ingo Molnar [this message]
2008-12-05 14:01 ` Frédéric Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081205134818.GA27039@elte.hu \
--to=mingo@elte.hu \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®