mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] tracing/ftrace: fix the check of ftrace_trace_task
Date: Fri, 5 Dec 2008 14:48:54 +0100	[thread overview]
Message-ID: <20081205134854.GB27039@elte.hu> (raw)
In-Reply-To: <alpine.DEB.1.10.0812041801480.32726@gandalf.stny.rr.com>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> 
> On Thu, 4 Dec 2008, Frederic Weisbecker wrote:
> 
> > Impact: fix default empty traces on function-graph-tracer
> > 
> > The actual ftrace_trace_task() checks if ftrace_pid_trace is 
> > allocated and return 1 if it is true. If it is NULL, it will check 
> > the bit of pid tracing flag for the current task (which are not set 
> > by default). So by default, a task is not traced. Actually all tasks 
> > should be traced by default and filter_by_pid when ftrace_pid_trace 
> > is allocated.
> 
> Heh, I thought my output look funny. The function tracer does not use 
> it since it registers a different function. But because the graph 
> tracer only shows the current task on switch (I did not look into trace 
> options) I could not really test it well.
> 
> -- Steve
> 
> Acked-by: Steven Rostedt <srostedt@redhat.com>

applied to tip/tracing/ftrace, thanks!

	Ingo

      reply	other threads:[~2008-12-05 13:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04 22:49 Frederic Weisbecker
2008-12-04 23:18 ` Steven Rostedt
2008-12-05 13:48   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081205134854.GB27039@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®