From: Alexey Dobriyan <adobriyan@gmail.com>
To: Alexander Beregalov <a.beregalov@gmail.com>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: convert to list_for_each()
Date: Sat, 6 Dec 2008 23:37:40 +0300 [thread overview]
Message-ID: <20081206203740.GA2264@x200.localdomain> (raw)
In-Reply-To: <20081206184905.GA19589@orion>
On Sat, Dec 06, 2008 at 09:49:05PM +0300, Alexander Beregalov wrote:
No, switch to list_for_each_entry() from the very beginning.
> --- a/drivers/staging/me4000/me4000.c
> +++ b/drivers/staging/me4000/me4000.c
> @@ -542,8 +542,7 @@ static void clear_board_info_list(void)
> struct me4000_ao_context *ao_context;
>
> /* Clear context lists */
> - for (board_p = me4000_board_info_list.next;
> - board_p != &me4000_board_info_list; board_p = board_p->next) {
> + list_for_each(board_p, &me4000_board_info_list) {
> board_info = list_entry(board_p, struct me4000_info, list);
> /* Clear analog output context list */
> while (!list_empty(&board_info->ao_context_list)) {
next prev parent reply other threads:[~2008-12-06 20:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-06 18:49 Alexander Beregalov
2008-12-06 20:37 ` Alexey Dobriyan [this message]
2008-12-07 1:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081206203740.GA2264@x200.localdomain \
--to=adobriyan@gmail.com \
--cc=a.beregalov@gmail.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®