From: Oliver Neukum <oliver@neukum.org>
To: Artem Bityutskiy <dedekind@yandex.ru>
Cc: Nick Andrew <nick@nick-andrew.net>,
Hiroshi DOYU <Hiroshi.DOYU@nokia.com>,
linux-kernel@vger.kernel.org, apw@shadowen.org
Subject: Re: [PATCH 1/1] fs: fix warning message with inserting a single space
Date: Mon, 8 Dec 2008 14:24:28 +0100 [thread overview]
Message-ID: <200812081424.29279.oliver@neukum.org> (raw)
In-Reply-To: <493D1E15.6060001@yandex.ru>
Am Montag, 8. Dezember 2008 14:16:05 schrieb Artem Bityutskiy:
> Nick Andrew wrote:
> > On Mon, Dec 08, 2008 at 01:54:12PM +0200, Hiroshi DOYU wrote:
> >> - printk(KERN_WARNING "%s: %s passed in a files array"
> >> + printk(KERN_WARNING "%s: %s passed in a files array "
> >> "with an index of 1!\n", __func__,
> >> s->s_type->name);
> >
> > Yep. These look like the same kind of thing:
> >
> > arch/powerpc/platforms/cell/iommu.c +1109
> > pr_debug("iommu: hash window doesn't fit in"
> > "real DMA window\n");
>
> Do we have such kind of check in checkpatch.pl? Would be useful.
No, it wouldn't. A kernel message should be grepable. So, when in doubt,
screw the screen width limit. Don't make making ungreppable messages
easier.
Regards
Oliver
prev parent reply other threads:[~2008-12-08 13:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 11:54 Hiroshi DOYU
2008-12-08 12:35 ` Nick Andrew
2008-12-08 13:16 ` Artem Bityutskiy
2008-12-08 13:22 ` Artem Bityutskiy
2008-12-08 13:24 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812081424.29279.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=Hiroshi.DOYU@nokia.com \
--cc=apw@shadowen.org \
--cc=dedekind@yandex.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@nick-andrew.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®