mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Wim Van Sebroeck <wim@iguana.be>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog: New library code
Date: Tue, 9 Dec 2008 16:54:40 +0000	[thread overview]
Message-ID: <20081209165440.64501e00@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20081209161425.GE32662@infomag.infomag.iguana.be>

On Tue, 9 Dec 2008 17:14:25 +0100
Wim Van Sebroeck <wim@iguana.be> wrote:

> Hi Alan,
> 
> The flue changed my weekend :-(. I do however have 2 general questions first:
> 
> > - Handles the temperature device
> Why don't we treat the temperature part not as a hwmon?

Because the temperature interface was there first and is part of the
existing kernel to user space API. Now that the device is abstracted I
agree entirely that it should also appear in hwmon and the support
library code can be extended to do this along with multiple watchdogs.
> 
> > - It does all the reboot, nowayout and module locking and housekeeping
> Why don't we use the shutdown methods of our platform and other devices instead of the reboot notifier setup?

As and when watchdogs are all platform devices we probably should. Right
now most of them are not and we don't really have a proper 'isa_device'
object yet. I see that as a migration path or an 'aspiration', but having
it in one place will make that easier to achieve after we have the common
API.

Likewise sysfs, classes and multiple watchdogs all want addressing but
that gets a lot easier once everything is using a common framework and a
passed 'struct watchdog' to make multiple instances just work.

Alan

  reply	other threads:[~2008-12-09 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-04 15:52 Alan Cox
2008-12-09 16:14 ` Wim Van Sebroeck
2008-12-09 16:54   ` Alan Cox [this message]
2009-03-20 11:06     ` Wim Van Sebroeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081209165440.64501e00@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wim@iguana.be \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®