From: Laurent Pinchart <laurent.pinchart@skynet.be>
To: Oliver Neukum <oliver@neukum.org>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
LKML <linux-kernel@vger.kernel.org>,
"Greg Kroah-Hartman" <gregkh@suse.de>,
linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb: make printk messges more searchable
Date: Wed, 10 Dec 2008 10:59:00 +0100 [thread overview]
Message-ID: <200812101059.01068.laurent.pinchart@skynet.be> (raw)
In-Reply-To: <200812101056.15457.oliver@neukum.org>
On Wednesday 10 December 2008, Oliver Neukum wrote:
> Am Mittwoch, 10. Dezember 2008 10:42:17 schrieb Laurent Pinchart:
> > Hi Wu,
> >
> > On Wednesday 10 December 2008, Wu Fengguang wrote:
> > > Make USB printk messages long and straightforward. One of these
> > > decorated USB error messages cost me some smart efforts to locate.
> >
> > That would make the code break the 80 columns limit.
> >
> > From "Documentation/CodingStyle":
> >
> > "The limit on the length of lines is 80 columns and this is a strongly
> > preferred limit."
>
> Too rigid an application is bad. The kernel must be greppable.
I've also been bitten by split strings when grepping kernel source code. A
cgrep that would unsplit strings before searching them would be nice :-)
Best regards,
Laurent Pinchart
next prev parent reply other threads:[~2008-12-10 9:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 7:29 Wu Fengguang
2008-12-10 9:42 ` Laurent Pinchart
2008-12-10 9:56 ` Oliver Neukum
2008-12-10 9:59 ` Laurent Pinchart [this message]
2008-12-10 12:58 ` Wu Fengguang
2008-12-10 15:39 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200812101059.01068.laurent.pinchart@skynet.be \
--to=laurent.pinchart@skynet.be \
--cc=fengguang.wu@intel.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oliver@neukum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®