From: Sam Ravnborg <sam@ravnborg.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] tags.sh: fix string equality testing
Date: Sun, 14 Dec 2008 00:14:34 +0100 [thread overview]
Message-ID: <20081213231434.GB32331@uranus.ravnborg.org> (raw)
In-Reply-To: <1228913318-6003-1-git-send-email-jirislaby@gmail.com>
On Wed, Dec 10, 2008 at 01:48:38PM +0100, Jiri Slaby wrote:
> Test of string equality in shells is =, not C-like ==.
>
> Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Here I also did some local modifcations.
See below.
Sam
>From 91a70f60c285587826702a93ae924e7b9d761f94 Mon Sep 17 00:00:00 2001
From: Jiri Slaby <jirislaby@gmail.com>
Date: Wed, 10 Dec 2008 13:48:38 +0100
Subject: [PATCH] kbuild: fix string equality testing in tags.sh
Test of string equality in shells is =, not C-like ==.
Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
---
scripts/tags.sh | 10 +++++-----
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/scripts/tags.sh b/scripts/tags.sh
index 3c814ba..4e75472 100755
--- a/scripts/tags.sh
+++ b/scripts/tags.sh
@@ -7,7 +7,7 @@
# Uses the following environment variables:
# ARCH, SUBARCH, srctree, src, obj
-if [ $KBUILD_VERBOSE == 1 ]; then
+if [ "$KBUILD_VERBOSE" = "1" ]; then
set -x
fi
@@ -18,7 +18,7 @@ ignore="( -name SCCS -o -name BitKeeper -o -name .svn -o \
-prune -o"
# Do not use full path is we do not use O=.. builds
-if [ "${KBUILD_SRC}" == "" ]; then
+if [ "${KBUILD_SRC}" = "" ]; then
tree=
else
tree=${srctree}/
@@ -135,10 +135,10 @@ xtags()
# Support um (which uses SUBARCH)
-if [ ${ARCH} == um ]; then
- if [ $SUBARCH == i386 ]; then
+if [ "${ARCH}" = "um" ]; then
+ if [ "$SUBARCH" = "i386" ]; then
archinclude=x86
- elif [ $SUBARCH == x86_64 ]; then
+ elif [ "$SUBARCH" = "x86_64" ]; then
archinclude=x86
else
archinclude=${SUBARCH}
--
1.5.6.GIT
prev parent reply other threads:[~2008-12-13 23:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 12:48 Jiri Slaby
2008-12-13 23:14 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081213231434.GB32331@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=jirislaby@gmail.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®