From: Andi Kleen <andi@firstfloor.org>
To: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: akpm@linux-foundation.org, andi@firstfloor.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH mmotm 1/5] nilfs2: fix problems of memory allocation in ioctl
Date: Sun, 14 Dec 2008 16:13:27 +0100 [thread overview]
Message-ID: <20081214151327.GM25779@one.firstfloor.org> (raw)
In-Reply-To: <20081214.210839.09550698.ryusuke@osrg.net>
> -#define KMALLOC_SIZE_MIN 4096 /* 4KB */
> -#define KMALLOC_SIZE_MAX 131072 /* 128 KB */
> +#define NILFS_IOCTL_KMALLOC_SIZE 8192 /* 8KB */
Better would be if you could go to PAGE_SIZE. order 0 allocations
are typically the fastest / least likely to stall.
Also in this case it's a good idea to use __get_free_pages()
directly, kmalloc tends to be become less efficient at larger
sizes.
-Andi
next prev parent reply other threads:[~2008-12-14 15:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 5:16 [PATCH mmotm 0/5] nilfs2 filesystem updates Ryusuke Konishi
2008-12-12 5:16 ` [PATCH mmotm 1/5] nilfs2: fix problems of memory allocation in ioctl Ryusuke Konishi
2008-12-12 5:16 ` [PATCH mmotm 2/5] nilfs2: cleanup nilfs_clear_inode Ryusuke Konishi
2008-12-12 5:16 ` [PATCH mmotm 3/5] nilfs2: avoid double error caused by nilfs_transaction_end Ryusuke Konishi
2008-12-12 5:17 ` [PATCH mmotm 4/5] nilfs2: insert explanations in gcinode file Ryusuke Konishi
2008-12-12 5:17 ` [PATCH mmotm 5/5] nilfs2: add maintainer Ryusuke Konishi
2008-12-12 7:50 ` [PATCH mmotm 3/5] nilfs2: avoid double error caused by nilfs_transaction_end Pekka Enberg
2008-12-12 13:47 ` [PATCH mmotm 1/5] nilfs2: fix problems of memory allocation in ioctl Andi Kleen
2008-12-12 18:48 ` Ryusuke Konishi
2008-12-12 20:24 ` Andi Kleen
2008-12-13 8:29 ` Ryusuke Konishi
2008-12-14 12:08 ` Ryusuke Konishi
2008-12-14 15:13 ` Andi Kleen [this message]
2008-12-15 6:58 ` Ryusuke Konishi
2008-12-15 10:17 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081214151327.GM25779@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=akpm@linux-foundation.org \
--cc=konishi.ryusuke@lab.ntt.co.jp \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®