From: David Miller <davem@davemloft.net>
To: adobriyan@gmail.com
Cc: rostedt@goodmis.org, linux-kernel@vger.kernel.org,
dada1@cosmosbay.com, mingo@elte.hu, akpm@linux-foundation.org,
acme@ghostprotocols.net
Subject: Re: Impact:
Date: Mon, 15 Dec 2008 22:38:10 -0800 (PST) [thread overview]
Message-ID: <20081215.223810.262172290.davem@davemloft.net> (raw)
In-Reply-To: <20081216011039.GA2458@x200.localdomain>
From: Alexey Dobriyan <adobriyan@gmail.com>
Date: Tue, 16 Dec 2008 04:10:39 +0300
> On Mon, Dec 15, 2008 at 12:20:19AM -0800, David Miller wrote:
> > > update rwlock initialization for nat_table
> > >
> > > Impact: clean up
> > >
> > > The commit e099a173573ce1ba171092aee7bb3c72ea686e59
> > > (netfilter: netns nat: per-netns NAT table) renamed the
> > > nat_table from __nat_table to nat_table without updating the
> > > __RW_LOCK_UNLOCKED(__nat_table.lock).
> > >
> > > Signed-off-by: Steven Rostedt <srostedt@redhat.com>
> >
> > Applied to net-2.6, thanks Steven.
> >
> > As Andrew mentioned this is a bug (albeit a "nano-bug" as you
> > called it :-) so I removed the Impact line in the commit
> > message when applying this.
>
> Speaking of Impact: lines, is this a new fashion or what?
I don't know what it is, but I find them pointless.
Just provide a proper verbose commit message and be done with it.
At the rate we're going we'll soon have commit messages like:
--------------------
Impact: Crashes kernel
Cause: Race between timer and workqueue
Implementation: ...
--------------------
I mean, spare me...
next prev parent reply other threads:[~2008-12-16 6:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-10 18:21 [PATCH] replace deprecated RW_LOCK_UNLOCKED in net/dccp/proto.c Steven Rostedt
2008-12-10 18:33 ` Eric Dumazet
2008-12-10 19:00 ` Steven Rostedt
2008-12-10 20:06 ` [PATCH] update rwlock initialization for nat_table Steven Rostedt
2008-12-11 22:18 ` Andrew Morton
2008-12-11 22:24 ` Steven Rostedt
2008-12-15 8:20 ` David Miller
2008-12-16 1:10 ` Impact: (was Re: [PATCH] update rwlock initialization for nat_table) Alexey Dobriyan
2008-12-16 1:19 ` Andrew Morton
2008-12-16 11:15 ` Arnaldo Carvalho de Melo
2008-12-16 6:38 ` David Miller [this message]
2008-12-16 23:00 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081215.223810.262172290.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=acme@ghostprotocols.net \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dada1@cosmosbay.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®