From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Suresh B Siddha <suresh.b.siddha@intel.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Ingo Molnar <mingo@elte.hu>, Dipankar Sarma <dipankar@in.ibm.com>,
Vatsa <vatsa@linux.vnet.ibm.com>,
Gautham R Shenoy <ego@in.ibm.com>,
Andi Kleen <andi@firstfloor.org>,
David Collier-Brown <davecb@sun.com>,
Tim Connors <tconnors@astro.swin.edu.au>,
Max Krasnyansky <maxk@qualcomm.com>,
Gregory Haskins <gregory.haskins@gmail.com>
Subject: Re: [RFC PATCH v5 7/7] sched: idle_balance() does not call load_balance_newidle()
Date: Mon, 15 Dec 2008 12:32:37 +0530 [thread overview]
Message-ID: <20081215070237.GF18403@balbir.in.ibm.com> (raw)
In-Reply-To: <20081211174323.2020.97965.stgit@drishya.in.ibm.com>
* Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com> [2008-12-11 23:13:23]:
> load_balance_newidle() does not get called if SD_BALANCE_NEWIDLE
> is set at higher level domain (3-CPU) and not in low level domain
> (2-MC).
>
> pulled_task is initialised to -1 and checked for non-zero which
> is always true if the lowest level sched_domain does not have
> SD_BALANCE_NEWIDLE flag set.
>
> Trivial fix to initialise pulled_task to zero.
>
This is already pulled in for 2.6.29, so I am not reviewing it. We can
drop it from the next patch series.
--
Balbir
prev parent reply other threads:[~2008-12-15 7:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-11 17:42 [RFC PATCH v5 0/7] Tunable sched_mc_power_savings=n Vaidyanathan Srinivasan
1970-01-01 0:13 ` Pavel Machek
2008-12-14 20:08 ` Vaidyanathan Srinivasan
2008-12-15 8:18 ` Peter Zijlstra
2008-12-11 17:42 ` [RFC PATCH v5 1/7] sched: Framework for sched_mc/smt_power_savings=N Vaidyanathan Srinivasan
2008-12-11 18:55 ` Balbir Singh
2008-12-11 19:07 ` Vaidyanathan Srinivasan
2008-12-11 17:42 ` [RFC PATCH v5 2/7] sched: favour lower logical cpu number for sched_mc balance Vaidyanathan Srinivasan
2008-12-15 6:12 ` Balbir Singh
2008-12-15 12:05 ` Vaidyanathan Srinivasan
2008-12-11 17:42 ` [RFC PATCH v5 3/7] sched: nominate preferred wakeup cpu Vaidyanathan Srinivasan
2008-12-15 6:40 ` Balbir Singh
2008-12-15 12:14 ` Vaidyanathan Srinivasan
2008-12-11 17:43 ` [RFC PATCH v5 4/7] sched: bias task wakeups to preferred semi-idle packages Vaidyanathan Srinivasan
2008-12-15 7:01 ` Balbir Singh
2008-12-15 8:25 ` Peter Zijlstra
2008-12-15 8:33 ` Peter Zijlstra
2008-12-15 8:46 ` Balbir Singh
2008-12-15 12:25 ` Vaidyanathan Srinivasan
2008-12-15 18:02 ` Balbir Singh
2008-12-16 7:25 ` Vaidyanathan Srinivasan
2008-12-15 8:43 ` Balbir Singh
2008-12-11 17:43 ` [RFC PATCH v5 5/7] sched: activate active load balancing in new idle cpus Vaidyanathan Srinivasan
2008-12-11 17:43 ` [RFC PATCH v5 6/7] sched: add SD_BALANCE_NEWIDLE at MC and CPU level for sched_mc>0 Vaidyanathan Srinivasan
2008-12-11 17:43 ` [RFC PATCH v5 7/7] sched: idle_balance() does not call load_balance_newidle() Vaidyanathan Srinivasan
2008-12-15 7:02 ` Balbir Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081215070237.GF18403@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=davecb@sun.com \
--cc=dipankar@in.ibm.com \
--cc=ego@in.ibm.com \
--cc=gregory.haskins@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=tconnors@astro.swin.edu.au \
--cc=vatsa@linux.vnet.ibm.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®