From: Herbert Xu <herbert@gondor.apana.org.au>
To: Sebastian Andrzej Siewior <linux-crypto@ml.breakpoint.cc>
Cc: Huang Ying <ying.huang@intel.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
"mingo@elte.hu" <mingo@elte.hu>,
"tglx@linutronix.de" <tglx@linutronix.de>
Subject: Re: [RFC PATCH crypto] AES: Add support to Intel AES-NI instructions
Date: Mon, 15 Dec 2008 22:28:46 +1100 [thread overview]
Message-ID: <20081215112846.GA31804@gondor.apana.org.au> (raw)
In-Reply-To: <20081215090745.GA4991@Chamillionaire.breakpoint.cc>
On Mon, Dec 15, 2008 at 10:07:45AM +0100, Sebastian Andrzej Siewior wrote:
>
> You have to it if you want to bypass the crypto layer and call asm
> functions directly and I'm not sure whether bypassing the crypto layer
> is a good thing. Both asm routines (the 32bit and 64bit) assume that
> keylen ist at +0 followed by enc key, dec key. Ach and they don't do the
> ALIGN thing.
>
> Herbert what do you thing?
I think it would be OK if it called the assembly routine directly
and we moved this under asm/x86-64. We should do the latter anyway
regardless of what we decide.
However, I'm skeptical about whether we should use of a fallback at
all rather than making this work in softirq context.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
prev parent reply other threads:[~2008-12-15 11:29 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 4:08 Huang Ying
2008-12-12 19:57 ` Sebastian Andrzej Siewior
2008-12-15 2:19 ` Huang Ying
2008-12-15 3:38 ` Herbert Xu
2008-12-15 5:14 ` Huang Ying
2008-12-15 5:21 ` Herbert Xu
2008-12-15 5:48 ` Huang Ying
2008-12-15 12:38 ` Herbert Xu
2008-12-16 23:31 ` Herbert Xu
2008-12-17 1:14 ` Huang Ying
2008-12-17 1:26 ` Herbert Xu
2008-12-17 3:33 ` Huang Ying
2008-12-17 3:39 ` Herbert Xu
2008-12-15 18:26 ` Suresh Siddha
2008-12-15 9:07 ` Sebastian Andrzej Siewior
2008-12-15 11:28 ` Herbert Xu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081215112846.GA31804@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=akpm@linux-foundation.org \
--cc=linux-crypto@ml.breakpoint.cc \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®