From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756443AbYLPBCW (ORCPT ); Mon, 15 Dec 2008 20:02:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750819AbYLPBCO (ORCPT ); Mon, 15 Dec 2008 20:02:14 -0500 Received: from fgwmail7.fujitsu.co.jp ([192.51.44.37]:59228 "EHLO fgwmail7.fujitsu.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750805AbYLPBCN (ORCPT ); Mon, 15 Dec 2008 20:02:13 -0500 From: KOSAKI Motohiro To: Eric Paris Subject: Re: [PATCH 1/3] filesystem notification: create fs/notify to contain all fs notification Cc: kosaki.motohiro@jp.fujitsu.com, linux-kernel@vger.kernel.org, hch@infradead.org, akpm@linux-foundation.org In-Reply-To: <20081215164409.2018.26639.stgit@paris.rdu.redhat.com> References: <20081215164016.2018.4813.stgit@paris.rdu.redhat.com> <20081215164409.2018.26639.stgit@paris.rdu.redhat.com> Message-Id: <20081216095546.06C7.KOSAKI.MOTOHIRO@jp.fujitsu.com> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Mailer: Becky! ver. 2.42 [ja] Date: Tue, 16 Dec 2008 10:02:09 +0900 (JST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi > Creating a generic filesystem notification interface, fsnotify, which will be > used by inotify, dnotify, and eventually fanotify is really starting to > clutter the fs directory. This patch simply moves inotify and dnotify into > fs/notify/inotify and fs/notify/dnotify respectively. > > Signed-off-by: Eric Paris > --- > > fs/Kconfig | 39 -- > fs/Makefile | 5 > fs/dnotify.c | 194 -------- > fs/inotify.c | 913 -------------------------------------- > fs/inotify_user.c | 778 -------------------------------- > fs/notify/Kconfig | 2 > fs/notify/Makefile | 2 > fs/notify/dnotify/Kconfig | 10 > fs/notify/dnotify/Makefile | 1 > fs/notify/dnotify/dnotify.c | 194 ++++++++ > fs/notify/inotify/Kconfig | 27 + > fs/notify/inotify/Makefile | 2 > fs/notify/inotify/inotify.c | 913 ++++++++++++++++++++++++++++++++++++++ > fs/notify/inotify/inotify_user.c | 778 ++++++++++++++++++++++++++++++++ > 14 files changed, 1931 insertions(+), 1927 deletions(-) > delete mode 100644 fs/dnotify.c > delete mode 100644 fs/inotify.c > delete mode 100644 fs/inotify_user.c > create mode 100644 fs/notify/Kconfig > create mode 100644 fs/notify/Makefile > create mode 100644 fs/notify/dnotify/Kconfig > create mode 100644 fs/notify/dnotify/Makefile > create mode 100644 fs/notify/dnotify/dnotify.c > create mode 100644 fs/notify/inotify/Kconfig > create mode 100644 fs/notify/inotify/Makefile > create mode 100644 fs/notify/inotify/inotify.c > create mode 100644 fs/notify/inotify/inotify_user.c 1) this mail only contain Kconfig and Makefile changing patch. iow, this patch doesn't contain file moving information. iow, patch statics and actual patch are different. 2) your latter patch doesn't depend on this patch. this patch doesn't have justification. I recommend to separate this patch.