Re: [Patch 2/3] via-sdmmc: via-sdmmc.c

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

From: Oliver Neukum <oliver@neukum.org>
To: JosephChan@via.com.tw
Cc: linux-kernel@vger.kernel.org
Subject: Re: [Patch 2/3] via-sdmmc: via-sdmmc.c
Date: Tue, 16 Dec 2008 12:58:02 +0100	[thread overview]
Message-ID: <200812161258.03787.oliver@neukum.org> (raw)
In-Reply-To: <C80EF34A3D2E494DBAF9AC29C7AE4EB808520F3B@exchtp03.taipei.via.com.tw>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1361 bytes --]

Am Dienstag, 16. Dezember 2008 12:41:35 schrieb JosephChan@via.com.tw:> +Â Â Â Â Â Â Â spin_lock_irqsave(&host->lock, flags);> +> +Â Â Â Â Â Â Â addrbase = vcrdr_chip->pcictrl_mmiobase;> +Â Â Â Â Â Â Â writeb(PCI_DMA_CLK_SDC, addrbase + PCIDMACLK_REG);> +Â Â Â Â Â Â Â vcrdr_chip->cur_device = DEV_SDC;> +> +Â Â Â Â Â Â Â addrbase = vcrdr_chip->sdhc_mmiobase;> +Â Â Â Â Â Â Â status = readw(addrbase + SDSTATUS_REG);> +Â Â Â Â Â Â Â if (!(status & SD_STS_SLOTG)) {> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â if (host->mrq) {> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â pr_err("%s: Card removed during transfer!\n",> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â  Â  Â  Â  mmc_hostname(host->mmc));> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â host->mrq->cmd->error = -ENOMEDIUM;> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â tasklet_schedule(&host->finish_tasklet);> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â }> +> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â addrbase = vcrdr_chip->pcictrl_mmiobase;> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â writeb(PCI_CLK_375K, addrbase + PCISDCCLK_REG);> +> +Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â via_reset_pcictrl(host);
This means a long delay with interrupts off. Is this really needed?
	Regards		Oliver

ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éÝ¶\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dÊ‡Ú™ë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

next prev parent reply	other threads:[~2008-12-16 11:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-16 11:41 JosephChan
2008-12-16 11:58 ` Oliver Neukum [this message]
2008-12-17 11:12   ` JosephChan
2008-12-16 13:31 ` Arnd Bergmann
2008-12-16 16:00   ` Ben Dooks
2008-12-17  9:45   ` JosephChan
2008-12-18 12:49     ` Arnd Bergmann
2008-12-22  7:17       ` JosephChan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200812161258.03787.oliver@neukum.org \
    --to=oliver@neukum.org \
    --cc=JosephChan@via.com.tw \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®