mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Herrmann <andreas.herrmann3@amd.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org,
	Dmitry Adamushko <dmitry.adamushko@gmail.com>
Subject: [PATCH 7/10] x86: microcode_amd: consolidate macro definitions
Date: Tue, 16 Dec 2008 19:17:45 +0100	[thread overview]
Message-ID: <20081216181745.GN7013@alberich.amd.com> (raw)
In-Reply-To: <20081216180639.GG7013@alberich.amd.com>


Signed-off-by: Andreas Herrmann <andreas.herrmann3@amd.com>
---
 arch/x86/kernel/microcode_amd.c |   16 +++-------------
 1 files changed, 3 insertions(+), 13 deletions(-)

diff --git a/arch/x86/kernel/microcode_amd.c b/arch/x86/kernel/microcode_amd.c
index 2856955..e68e723 100644
--- a/arch/x86/kernel/microcode_amd.c
+++ b/arch/x86/kernel/microcode_amd.c
@@ -75,15 +75,9 @@ struct microcode_amd {
 	unsigned int mpb[0];
 };
 
-#define UCODE_MAX_SIZE          (2048)
-#define DEFAULT_UCODE_DATASIZE	(896)
-#define MC_HEADER_SIZE		(sizeof(struct microcode_header_amd))
-#define DEFAULT_UCODE_TOTALSIZE (DEFAULT_UCODE_DATASIZE + MC_HEADER_SIZE)
-#define DWSIZE			(sizeof(u32))
-/* For now we support a fixed ucode total size only */
-#define get_totalsize(mc) \
-	((((struct microcode_amd *)mc)->hdr.mc_patch_data_len * 28) \
-	 + MC_HEADER_SIZE)
+#define UCODE_MAX_SIZE			2048
+#define UCODE_CONTAINER_SECTION_HDR	8
+#define UCODE_CONTAINER_HEADER_SIZE	12
 
 /* serialize access to the physical write */
 static DEFINE_SPINLOCK(microcode_update_lock);
@@ -222,7 +216,6 @@ static void *get_next_ucode(const u8 *buf, unsigned int size,
 			    unsigned int *mc_size)
 {
 	unsigned int total_size;
-#define UCODE_CONTAINER_SECTION_HDR	8
 	u8 section_hdr[UCODE_CONTAINER_SECTION_HDR];
 	void *mc;
 
@@ -255,14 +248,12 @@ static void *get_next_ucode(const u8 *buf, unsigned int size,
 		} else
 			*mc_size = total_size + UCODE_CONTAINER_SECTION_HDR;
 	}
-#undef UCODE_CONTAINER_SECTION_HDR
 	return mc;
 }
 
 
 static int install_equiv_cpu_table(const u8 *buf)
 {
-#define UCODE_CONTAINER_HEADER_SIZE	12
 	u8 *container_hdr[UCODE_CONTAINER_HEADER_SIZE];
 	unsigned int *buf_pos = (unsigned int *)container_hdr;
 	unsigned long size;
@@ -291,7 +282,6 @@ static int install_equiv_cpu_table(const u8 *buf)
 	}
 
 	return size + UCODE_CONTAINER_HEADER_SIZE; /* add header length */
-#undef UCODE_CONTAINER_HEADER_SIZE
 }
 
 static void free_equiv_cpu_table(void)
-- 
1.6.0.4




  parent reply	other threads:[~2008-12-16 18:18 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-16 18:06 [PATCH 0/10] x86: microcode_amd: fixes and cleanup Andreas Herrmann
2008-12-16 18:07 ` [PATCH 1/10] x86: microcode_amd: fix wrong handling of equivalent CPU id Andreas Herrmann
2008-12-16 18:08 ` [PATCH 2/10] x86: microcode_amd: fix typos and trailing whitespaces in log messages Andreas Herrmann
2008-12-16 18:11 ` [PATCH 3/10] x86: microcode_amd: fix checkpatch warnings/errors Andreas Herrmann
2008-12-16 18:13 ` [PATCH 4/10] x86: microcode_amd: fix compile warning Andreas Herrmann
2008-12-16 18:14 ` [PATCH 5/10] x86: microcode_amd: don't pass superfluous function pointer for get_ucode_data Andreas Herrmann
2008-12-16 18:16 ` [PATCH 6/10] x86: microcode_amd: replace inline asm by common rdmsr/wrmsr functions Andreas Herrmann
2008-12-16 18:17 ` Andreas Herrmann [this message]
2008-12-16 18:20 ` [PATCH 8/10] x86: microcode_amd: remove (wrong) chipset deivce ID checks Andreas Herrmann
2008-12-16 18:21 ` [PATCH 9/10] x86: microcode_amd: use 'packed' attribute for structs Andreas Herrmann
2008-12-16 18:22 ` [PATCH 10/10] x86: microcode_amd: modify log messages Andreas Herrmann
2008-12-16 23:22 ` [PATCH 0/10] x86: microcode_amd: fixes and cleanup Dmitry Adamushko
2008-12-16 23:24   ` Dmitry Adamushko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081216181745.GN7013@alberich.amd.com \
    --to=andreas.herrmann3@amd.com \
    --cc=dmitry.adamushko@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®