From: Ingo Molnar <mingo@elte.hu>
To: Jaswinder Singh <jaswinder@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [PATCH] x86: process.c declare c1e_remove_cpu before they get used
Date: Thu, 18 Dec 2008 13:36:13 +0100 [thread overview]
Message-ID: <20081218123613.GE25715@elte.hu> (raw)
In-Reply-To: <1229536205.23068.6.camel@jaswinder.satnam>
* Jaswinder Singh <jaswinder@infradead.org> wrote:
> Impact: cleanup
>
> Included asm/idle.h for c1e_remove_cpu declaration.
>
> Signed-off-by: Jaswinder Singh <jaswinder@infradead.org>
> ---
> arch/x86/kernel/process.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/x86/kernel/process.c b/arch/x86/kernel/process.c
> index f50f8bf..25313de 100644
> --- a/arch/x86/kernel/process.c
> +++ b/arch/x86/kernel/process.c
> @@ -10,6 +10,7 @@
> #include <linux/ftrace.h>
> #include <asm/system.h>
> #include <asm/apic.h>
> +#include <asm/idle.h>
>
> unsigned long idle_halt;
> EXPORT_SYMBOL(idle_halt);
hm, why is this needed? Have you seen a compiler warning?
Ingo
next prev parent reply other threads:[~2008-12-18 12:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-17 17:50 Jaswinder Singh
2008-12-18 12:36 ` Ingo Molnar [this message]
2008-12-18 18:37 ` Jaswinder Singh
2008-12-18 21:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218123613.GE25715@elte.hu \
--to=mingo@elte.hu \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®