From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754745AbYLSVkp (ORCPT ); Fri, 19 Dec 2008 16:40:45 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752128AbYLSVjF (ORCPT ); Fri, 19 Dec 2008 16:39:05 -0500 Received: from www.tglx.de ([62.245.132.106]:55803 "EHLO www.tglx.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752028AbYLSVjD (ORCPT ); Fri, 19 Dec 2008 16:39:03 -0500 Message-Id: <20081219211948.821299520@linutronix.de> References: <20081219211656.875192771@linutronix.de> User-Agent: quilt/0.46-1 Date: Fri, 19 Dec 2008 21:23:06 -0000 From: Thomas Gleixner To: LKML Cc: Ingo Molnar , Steven Rostedt , Peter Zijlstra , Clark Williams , Gregory Haskins , Linux-rt Subject: [patch 6/7] rtmutex: remove useless schedule enforcement Content-Disposition: inline; filename=rtmutex-remove-useless-schedule-enforcement.patch Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org For !mtx the call to schedule() is forced even if the waiter is already woken (waiter.task == NULL). This makes no sense at all and is just waste. Signed-off-by: Thomas Gleixner --- kernel/rtmutex.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-2.6.24/kernel/rtmutex.c =================================================================== --- linux-2.6.24.orig/kernel/rtmutex.c +++ linux-2.6.24/kernel/rtmutex.c @@ -1402,7 +1402,7 @@ rt_read_slowlock(struct rw_mutex *rwm, i debug_rt_mutex_print_deadlock(&waiter); - if (!mtx || waiter.task) + if (waiter.task) schedule_rt_mutex(mutex); spin_lock_irqsave(&mutex->wait_lock, flags); @@ -1548,7 +1548,7 @@ rt_write_slowlock(struct rw_mutex *rwm, debug_rt_mutex_print_deadlock(&waiter); - if (!mtx || waiter.task) + if (waiter.task) schedule_rt_mutex(mutex); spin_lock_irqsave(&mutex->wait_lock, flags); --