From: Clifford Wolf <clifford@clifford.at>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Adrian Cox <adrian@humboldt.co.uk>
Subject: [PATCH] Fixed i2c-mpc driver for multi-master i2c busses.
Date: Mon, 22 Dec 2008 14:55:42 +0100 [thread overview]
Message-ID: <20081222135542.GA7317@clifford.at> (raw)
Fixed i2c-mpc driver for multi-master i2c busses.
Simply retry on arbitration lost until xfer is successfull,
a non-arbitration-lost error is triggered or the 1s timeout
is hit.
Tested with a freescale MPC8349E host cpu.
Signed-off-by: Clifford Wolf <clifford@clifford.at>
--- ./drivers/i2c/busses/i2c-mpc.c (revision 2186)
+++ ./drivers/i2c/busses/i2c-mpc.c (revision 2187)
@@ -133,16 +133,16 @@
if (result < 0)
return result;
+ if (x & CSR_MAL) {
+ pr_debug("I2C: MAL\n");
+ return -EAGAIN;
+ }
+
if (!(x & CSR_MCF)) {
pr_debug("I2C: unfinished\n");
return -EIO;
}
- if (x & CSR_MAL) {
- pr_debug("I2C: MAL\n");
- return -EIO;
- }
-
if (writing && (x & CSR_RXAK)) {
pr_debug("I2C: No RXAK\n");
/* generate stop */
@@ -256,11 +256,11 @@
static int mpc_xfer(struct i2c_adapter *adap, struct i2c_msg *msgs, int num)
{
struct i2c_msg *pmsg;
- int i;
- int ret = 0;
+ int i, ret;
unsigned long orig_jiffies = jiffies;
struct mpc_i2c *i2c = i2c_get_adapdata(adap);
+restart:
mpc_i2c_start(i2c);
/* Allow bus up to 1s to become not busy */
@@ -280,7 +280,7 @@
schedule();
}
- for (i = 0; ret >= 0 && i < num; i++) {
+ for (i = 0, ret = 0; ret >= 0 && i < num; i++) {
pmsg = &msgs[i];
pr_debug("Doing %s %d bytes to 0x%02x - %d of %d messages\n",
pmsg->flags & I2C_M_RD ? "read" : "write",
@@ -291,7 +291,13 @@
else
ret =
mpc_write(i2c, pmsg->addr, pmsg->buf, pmsg->len, i);
+ if (ret == -EAGAIN) {
+ pr_debug("Lost i2c arbitration -> retry.\n");
+ mpc_i2c_stop(i2c);
+ goto restart;
+ }
}
+
mpc_i2c_stop(i2c);
return (ret < 0) ? ret : num;
}
next reply other threads:[~2008-12-22 14:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-22 13:55 Clifford Wolf [this message]
2008-12-22 21:01 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081222135542.GA7317@clifford.at \
--to=clifford@clifford.at \
--cc=adrian@humboldt.co.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®