From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Julia Lawall <julia@diku.dk>
Cc: kernel@pengutronix.de, linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] arch/arm/plat-mxc: Add local_irq_restore in error handling code
Date: Mon, 22 Dec 2008 16:33:09 +0000 [thread overview]
Message-ID: <20081222163309.GA16392@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0812212153570.3635@ask.diku.dk>
On Sun, Dec 21, 2008 at 09:54:23PM +0100, Julia Lawall wrote:
> There is a call to local_irq_restore in the normal exit case, so it would
> seem that there should be one on an error return as well.
Please check what's queued up for the next merge; a similar change is
already merged as part of a larger patch. (which is more correct
since it calls local_irq_restore before the printk.)
prev parent reply other threads:[~2008-12-22 16:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-21 20:54 Julia Lawall
2008-12-21 22:27 ` Sascha Hauer
2008-12-22 16:33 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081222163309.GA16392@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®