From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <tj@kernel.org>
Cc: Robert Hancock <hancockr@shaw.ca>,
ide <linux-ide@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sata_sil: add Large Block Transfer support
Date: Tue, 23 Dec 2008 10:10:33 +0000 [thread overview]
Message-ID: <20081223101033.70c74ec7@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <49506BBC.8040600@kernel.org>
> > We know the register's always MMIO on this controller, so it's slightly
> > more optimal to avoid the conditional in there.
>
> Yeah, by a small margin but I think the consensus was to use
> ioread/write no matter what if it's mapped using iomap. I don't think
> we guarantee iomapped address == mmio address after all.
This was discussed before - using writel/readl on iomap is wrong. It may
happen to work on some platforms but shouldn't be expected to work on all.
prev parent reply other threads:[~2008-12-23 10:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-15 2:16 Robert Hancock
2008-12-22 10:19 ` Tejun Heo
2008-12-23 4:35 ` Robert Hancock
2008-12-23 4:40 ` Tejun Heo
2008-12-23 10:10 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081223101033.70c74ec7@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=hancockr@shaw.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®