From: Andi Kleen <andi@firstfloor.org>
To: "H. Peter Anvin" <hpa@kernel.org>
Cc: Jaswinder Singh <jaswinder@infradead.org>,
Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
x86 maintainers <x86@kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: traps.c replace #if CONFIG_X86_32 with #ifdef CONFIG_X86_32
Date: Tue, 23 Dec 2008 19:48:26 +0100 [thread overview]
Message-ID: <20081223184826.GA496@one.firstfloor.org> (raw)
In-Reply-To: <49512BF5.2010705@kernel.org>
On Tue, Dec 23, 2008 at 10:20:37AM -0800, H. Peter Anvin wrote:
> > return;
> > #endif
>
> Applied to tip:x86/fpu, thanks.
>
> Andi: you might have a perspective on this: in math_error() we bail out
> if there is no error on i386, but not on x86-64. I am rather assuming
> that is because it simply can't happen on x86-64 (no IRQ 13 bullshit) so
> it wasn't necessary?
Probably yes because it was not needed. Don't remember the exact circumstances,
sorry.
But dropping the #ifdef should be fine obviously.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-12-23 18:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-23 16:20 Jaswinder Singh
2008-12-23 18:20 ` H. Peter Anvin
2008-12-23 18:48 ` Andi Kleen [this message]
2008-12-23 20:32 ` Chuck Ebbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081223184826.GA496@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=hpa@kernel.org \
--cc=jaswinder@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®