Re: [PATCH, RESEND3] getrusage: fill ru_maxrss value

[Jiri Pirko <jpirko@redhat.com>]

On Wed, 24 Dec 2008 18:42:48 +0100
Oleg Nesterov <oleg@redhat.com> wrote:


> > > and we need good comment. e.g. /* Convert to KB */
> > > or good macros (likely linux/fs/proc/meminfo.c::K() macro)
> 
> Yes! Please ;) I just can't parse the code above, I am not compiler.
> Even
> 
> 	r->ru_maxrss *= (PAGE_SIZE / 1024); /* convert pages to KBs */
> 
> is much better, imho. Or at least just add the comment, so the
> poor reader can understand what the code does without parsing.
Fine
> 
> > > In addision, you also need change man pages and notice to linux-api mailing list.
> > I cc'ed this list while I was sending the patch.
> 
> Hmm. The biggest mistake with this patch is that you lost the
> CC list completely ;) Adding Hugh.
> 
> > I was not aware I
> > should change the man page. Will do that too.
> 
> Well. I don't think you must change the man page. Of course it
> would be nice if you do, but in a separate patch please. But
> you must cc Michael at least ;)
I cc'ed him with in my patch post - It has disappeared later in RE. 
> 
> Oleg.
>