Re: [patch] Performance Counters for Linux, v5

[Ingo Molnar <mingo@elte.hu>]

* KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> Hi Ingo,
> 
> Currently, -tip tree can't build on my ia64 box.
> because..
> 
> >  create mode 100644 Documentation/perf-counters.txt
> >  delete mode 100644 arch/x86/include/asm/intel_arch_perfmon.h
> >  create mode 100644 arch/x86/include/asm/perf_counter.h
> >  create mode 100644 arch/x86/kernel/cpu/perf_counter.c
> >  rename arch/x86/kernel/{signal_32.c => signal.c} (74%)
> >  delete mode 100644 arch/x86/kernel/signal_64.c
> >  create mode 100644 include/linux/perf_counter.h
> >  create mode 100644 kernel/perf_counter.c
> 
> 
> Only x86 has <asm/perf_counter.h>.

thanks - the fix below resolves it, right?

	Ingo

>From 26c6f31fe04454177513b8b8539e8197ff897703 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Thu, 25 Dec 2008 09:02:11 +0100
Subject: [PATCH] perfcounters: include asm/perf_counter.h only if CONFIG_PERF_COUNTERS=y

Impact: build fix on ia64

KOSAKI Motohiro reported that -tip doesnt build on ia64 because
asm/perf_counter.h only exists on x86 for now. Fix it.

Reported-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 include/linux/perf_counter.h |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

diff --git a/include/linux/perf_counter.h b/include/linux/perf_counter.h
index ec77d16..cc3a75a 100644
--- a/include/linux/perf_counter.h
+++ b/include/linux/perf_counter.h
@@ -14,7 +14,10 @@
 #define _LINUX_PERF_COUNTER_H
 
 #include <asm/atomic.h>
-#include <asm/perf_counter.h>
+
+#ifdef CONFIG_PERF_COUNTERS
+# include <asm/perf_counter.h>
+#endif
 
 #include <linux/list.h>
 #include <linux/mutex.h>