From: Grant Grundler <grundler@parisc-linux.org>
To: Micha? Miros?aw <mirq-linux@rere.qmqm.pl>
Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: RFC: pci_write_bits*() convenience functions
Date: Thu, 25 Dec 2008 01:20:27 -0700 [thread overview]
Message-ID: <20081225082027.GB11032@colo.lackof.org> (raw)
In-Reply-To: <20081223215938.GA32714@rere.qmqm.pl>
On Tue, Dec 23, 2008 at 10:59:38PM +0100, Micha? Miros?aw wrote:
...
> What's interesting, there are 2039 lines where pci_read_config_*() is used
> and in only about 161 the return value is checked (as of current linux-2.6.git
> tree: commit 3d44cc3e01..., quick grep test).
A very few of those config reads are for flushing MMIO commands to devices.
ISTR we had a case where resetting the device would cause MMIO reads to
Master Abort (timeout). It's ok for config cycles to Master Abort.
It's generally NOT OK for MMIO cycles to Master Abort.
However, your point is correct. Most of the time, we (driver writers) assume
the config cycle will either succeed or return ~0 (to indicate Master Abort).
And in some very few and extremely old PCI machines, return 0.
hth,
grant
next prev parent reply other threads:[~2008-12-25 8:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-23 21:59 Michał Mirosław
2008-12-25 8:20 ` Grant Grundler [this message]
2008-12-30 21:41 ` RFC: pci_write_bits*() convenience functions v.2 Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081225082027.GB11032@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®