mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@suse.cz>
To: Theodore Tso <tytso@mit.edu>, "H. Peter Anvin" <hpa@zytor.com>,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: SD/MMC cards: how crappy they are?
Date: Fri, 26 Dec 2008 23:39:08 +0100	[thread overview]
Message-ID: <20081226223908.GA2260@atrey.karlin.mff.cuni.cz> (raw)
In-Reply-To: <20081202165608.GD18162@mit.edu>

Hi!

> If this is your random eject out from your HP laptop problem, note
> that random ejects while the card is writing can cause corruption of
> the flash translation layer (FTL), which for some really crappy cards,
> can permanently damage them; hopefully most of those are gone from the
> market, but I wouldn't be positive about that.  The better ones will
> have some kind of journalling scheme for their FTL...
> 
> Fsck does have a force rewrite option, although it's not the default.
> You have to answer "n" to ignore error, and then yes to "force
> rewrite".  I should perhaps change that; my worry at the time was a
> transient read error tricking e2fsck into blowing away the contents of
> what was actually a good sector.  Of course, that will only help

Yes, I think that should be changed. Transient read errors are not
common, while bad blocks fixed by rewrite are quite common.
> 
> Badblocks -n will fix the problem, since it will do a non-destructive
> read/write test over the entire disk.  Patches to add an
> forced-rewrite mode to the standard r/o badblocks sweep (so we only
> write to a sector that has a read error) would be gratefully accepted.

badblocks -n took > 8hours on 32GB flash, so no, that's not usable. I
started digging into badblocks (please take a look/apply following
documentation updates, I only understood some stuff when reading the
source)... And I wish I'd known about SIGALARM before.

Question: does badblocks expect the media to be valied ext2/3/4
filesystem? It seems so...

								Pavel

Binary files e2fsprogs-1.41.3-clean/misc/badblocks and e2fsprogs-1.41.3/misc/badblocks differ
diff -ur e2fsprogs-1.41.3-clean/misc/badblocks.8 e2fsprogs-1.41.3/misc/badblocks.8
--- e2fsprogs-1.41.3-clean/misc/badblocks.8	2008-12-26 23:08:55.000000000 +0100
+++ e2fsprogs-1.41.3/misc/badblocks.8	2008-12-26 23:18:56.000000000 +0100
@@ -173,6 +173,10 @@
 read-only test is done.  This option must not be combined with the 
 .B \-w
 option, as they are mutually exclusive.
+
+This will read the block to be tested, then overwrite it with few different
+patterns, then write old data back. If something goes very wrong during the
+test (powerfail?) it may still damage the data.
 .TP
 .B \-s
 Show the progress of the scan by writing out the block numbers as they
@@ -211,6 +215,10 @@
 bad blocks. Therefore it is recommended to use it only when one wants
 to know if there are any bad blocks at all on the device, and not when
 the list of bad blocks is wanted.
+
+You can send SIGALARM to make badblocks report its progress. You can
+send SIGTERM to make badblocks terminate; it will catch the signal, clean
+up and exit.
 .SH AUTHOR
 .B badblocks
 was written by Remy Card <Remy.Card@linux.org>.  Current maintainer is

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2008-12-26 22:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-02 14:48 Pavel Machek
2008-12-02 16:30 ` H. Peter Anvin
2008-12-02 16:56   ` Theodore Tso
2008-12-02 17:59     ` H. Peter Anvin
2008-12-04 10:32       ` Pavel Machek
2008-12-04 19:03         ` H. Peter Anvin
2008-12-26 21:46           ` Pavel Machek
2008-12-26 21:49             ` H. Peter Anvin
2008-12-26 22:39     ` Pavel Machek [this message]
2008-12-27  1:03       ` Ben Pfaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081226223908.GA2260@atrey.karlin.mff.cuni.cz \
    --to=pavel@suse.cz \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®