From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752979AbYL2STR (ORCPT ); Mon, 29 Dec 2008 13:19:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752041AbYL2STB (ORCPT ); Mon, 29 Dec 2008 13:19:01 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:52802 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752026AbYL2STA (ORCPT ); Mon, 29 Dec 2008 13:19:00 -0500 From: "Rafael J. Wysocki" To: Len Brown Subject: [PATCH] ACPI: Do not modify SCI_EN directly Date: Mon, 29 Dec 2008 19:19:07 +0100 User-Agent: KMail/1.10.3 (Linux/2.6.28-rjw; KDE/4.1.3; x86_64; ; ) Cc: ACPI Devel Maling List , LKML , pm list MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-2" Content-Disposition: inline Message-Id: <200812291919.07663.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by alpha id mBTIrEX1000653 From: Rafael J. Wysocki According to the ACPI specification the SCI_EN flag is controlled bythe hardware, which sets this flag to inform the kernel that ACPI isenabled. For this reason, we shouldn't try to modify SCI_ENdirectly. Also, we don't need to do it in irqrouter_resume(), sincelower-level resume code takes care of enabling ACPI in case it hasn'tbeen enabled by the BIOS before passing control to the kernel (whichby the way is against the ACPI specification). Signed-off-by: Rafael J. Wysocki --- drivers/acpi/pci_link.c | 4 ---- 1 file changed, 4 deletions(-) Index: linux-2.6/drivers/acpi/pci_link.c===================================================================--- linux-2.6.orig/drivers/acpi/pci_link.c+++ linux-2.6/drivers/acpi/pci_link.c@@ -793,10 +793,6 @@ static int irqrouter_resume(struct sys_d struct list_head *node = NULL; struct acpi_pci_link *link = NULL; -- /* Make sure SCI is enabled again (Apple firmware bug?) */- acpi_set_register(ACPI_BITREG_SCI_ENABLE, 1);- list_for_each(node, &acpi_link.entries) { link = list_entry(node, struct acpi_pci_link, node); if (!link) {{.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I