mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Joe Peterson <joe@skyrush.com>,
	LKML <linux-kernel@vger.kernel.org>,
	kosaki.motohiro@jp.fujitsu.com
Subject: Re: [BUG?] tty doesn't handle ^D at cooked/non-cooked switching corner case
Date: Tue, 30 Dec 2008 13:44:27 +0000	[thread overview]
Message-ID: <20081230134427.003ff13a@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <20081230201932.128D.KOSAKI.MOTOHIRO@jp.fujitsu.com>

On Tue, 30 Dec 2008 21:00:23 +0900 (JST)
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> wrote:

> Hi tty expert,
> 
> Recently, ruby (scripting program language) developing group found
> that linux doesn't handle ^D properly at cooked/non-cooked switching
> corner case.

I don't believe the behaviour of input characters typed across that
boundary is defined by the standards at all. That said I think the
behaviour you expect is reasonable.

> They create following patch. is it right way?

You could recompute minimum in this case but zero is definitely
incorrect. I think what you would actually need to do is to extract out
the code just below do_it_again: which computes minimum and recompute it
properly.

Alan

  reply	other threads:[~2008-12-30 13:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-30 12:00 KOSAKI Motohiro
2008-12-30 13:44 ` Alan Cox [this message]
2009-01-03  0:34   ` KOSAKI Motohiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081230134427.003ff13a@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=joe@skyrush.com \
    --cc=kosaki.motohiro@jp.fujitsu.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®