mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>,
	ebiederm@xmission.com, bastian@waldi.eu.org, daniel@hozac.com,
	xemul@openvz.org, containers@lists.osdl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 5/7][v4] Protect cinit from blocked fatal signals
Date: Tue, 30 Dec 2008 16:04:45 -0800 (PST)	[thread overview]
Message-ID: <20081231000445.CEBC8FC278@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Wednesday, 24 December 2008 17:09:31 +0100 <20081224160931.GC11593@redhat.com>

> > + * If @signal refers to a container-init and @signr is neither SIGKILL nor
> > + * SIGSTOP, it was queued because it was blocked when it was posted.
> 
> This is not right too. It is possible that init had a handler when
> the signal was sent, and the handler was set to SIG_DFL before the
> signal was dequeued.

do_sigaction's sig_handler_ignored() should exclude that.


Thanks,
Roland

  parent reply	other threads:[~2008-12-31  0:05 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-24 11:44 [PATCH 0/7][v4] Container-init signal semantics Sukadev Bhattiprolu
2008-12-24 11:50 ` [RFC][PATCH 1/7][v4] Remove 'handler' parameter to tracehook functions Sukadev Bhattiprolu
2008-12-24 11:50 ` [RFC][PATCH 2/7][v4] Protect init from unwanted signals more Sukadev Bhattiprolu
2008-12-24 16:35   ` Oleg Nesterov
2008-12-24 21:11     ` Sukadev Bhattiprolu
2008-12-24 11:51 ` [RFC][PATCH 3/7][v4] Define siginfo_from_ancestor_ns() Sukadev Bhattiprolu
2008-12-24 16:28   ` Oleg Nesterov
2008-12-24 21:24     ` Sukadev Bhattiprolu
2008-12-24 22:03       ` Oleg Nesterov
2008-12-27 20:38         ` Sukadev Bhattiprolu
2008-12-24 11:51 ` [RFC][PATCH 4/7][v4] Protect cinit from unblocked SIG_DFL signals Sukadev Bhattiprolu
2008-12-24 11:52 ` [RFC][PATCH 5/7][v4] Protect cinit from blocked fatal signals Sukadev Bhattiprolu
2008-12-24 16:09   ` Oleg Nesterov
2008-12-24 21:25     ` Sukadev Bhattiprolu
2008-12-31  0:04     ` Roland McGrath [this message]
2009-01-05 12:24       ` Oleg Nesterov
2008-12-24 11:53 ` [RFC][PATCH 6/7][v4] SI_USER: Masquerade si_pid when crossing pid ns boundary Sukadev Bhattiprolu
2008-12-24 15:43   ` Oleg Nesterov
2008-12-24 16:18     ` Oleg Nesterov
2008-12-24 21:08     ` Sukadev Bhattiprolu
2008-12-24 11:53 ` [RFC][PATCH 7/7][v4] SI_TKILL: " Sukadev Bhattiprolu
2008-12-24 15:55   ` Oleg Nesterov
2008-12-24 21:04     ` Sukadev Bhattiprolu
2008-12-24 21:34       ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081231000445.CEBC8FC278@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=bastian@waldi.eu.org \
    --cc=containers@lists.osdl.org \
    --cc=daniel@hozac.com \
    --cc=ebiederm@xmission.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=sukadev@linux.vnet.ibm.com \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®