Re: [PATCH 2/2] mmc_block: ensure all sectors that do not have errors are read

[Pierre Ossman <drzeus@drzeus.cx>]

[-- Attachment #1: Type: text/plain, Size: 1179 bytes --]

On Mon, 22 Dec 2008 13:29:06 +0200
Adrian Hunter <ext-adrian.hunter@nokia.com> wrote:

> Pierre Ossman wrote:
> > 
> > Unfortunately, there is no guarantee that the sg list will be sector
> > aligned.
> 
> OK.  I am curious though - do you know anywhere in the kernel that actually
> does submit I/O in buffers that are not aligned to 512?
> 

Not really, no. Not that I've gone digging.

> 
> From: Adrian Hunter <ext-adrian.hunter@nokia.com>
> Subject: [PATCH] mmc_block: ensure all sectors that do not have errors are read
> 
> If a card encounters an ECC error while reading a sector it will
> timeout.  Instead of reporting the entire I/O request as having
> an error, redo the I/O one sector at a time so that all readable
> sectors are provided to the upper layers.
> 
> Signed-off-by: Adrian Hunter <ext-adrian.hunter@nokia.com>
> ---

Queued up. Thanks for sticking through this somewhat long review
process. :)

Rgds
-- 
     -- Pierre Ossman

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 197 bytes --]