From: "J. Bruce Fields" <bfields@fieldses.org>
To: "Américo Wang" <xiyou.wangcong@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-nfs@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [Patch] fs/nfs/nfs4proc.c: make nfs4_map_errors() static
Date: Thu, 1 Jan 2009 19:11:16 -0500 [thread overview]
Message-ID: <20090102001116.GB31840@fieldses.org> (raw)
In-Reply-To: <20081225215523.GH3130@hack.private>
On Thu, Dec 25, 2008 at 09:55:23PM +0000, Américo Wang wrote:
>
> nfs4_map_errors() can become static.
>
> Signed-off-by: WANG Cong <wangcong@zeuux.org>
> Cc: J. Bruce Fields <bfields@fieldses.org>
Thanks, applied for 2.6.29.--b.
>
> ---
> diff --git a/fs/nfs/nfs4_fs.h b/fs/nfs/nfs4_fs.h
> index ea79064..b8fb6a6 100644
> --- a/fs/nfs/nfs4_fs.h
> +++ b/fs/nfs/nfs4_fs.h
> @@ -174,7 +174,6 @@ extern ssize_t nfs4_listxattr(struct dentry *, char *, size_t);
>
>
> /* nfs4proc.c */
> -extern int nfs4_map_errors(int err);
> extern int nfs4_proc_setclientid(struct nfs_client *, u32, unsigned short, struct rpc_cred *);
> extern int nfs4_proc_setclientid_confirm(struct nfs_client *, struct rpc_cred *);
> extern int nfs4_proc_async_renew(struct nfs_client *, struct rpc_cred *);
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 83e700a..91e46ec 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -69,7 +69,7 @@ static int _nfs4_proc_lookup(struct inode *dir, const struct qstr *name, struct
> static int _nfs4_proc_getattr(struct nfs_server *server, struct nfs_fh *fhandle, struct nfs_fattr *fattr);
>
> /* Prevent leaks of NFSv4 errors into userland */
> -int nfs4_map_errors(int err)
> +static int nfs4_map_errors(int err)
> {
> if (err < -1000) {
> dprintk("%s could not handle NFSv4 error %d\n",
>
prev parent reply other threads:[~2009-01-02 0:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-25 21:55 Américo Wang
2009-01-02 0:11 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090102001116.GB31840@fieldses.org \
--to=bfields@fieldses.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®