mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sergei Trofimovich <slyfox@uvaga.by>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>,
	torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] i8k: Add Dell Vostro systems
Date: Fri, 2 Jan 2009 18:45:22 +0200	[thread overview]
Message-ID: <20090102184522.07bc2b86@slyfox.slynet.org> (raw)
In-Reply-To: <20090102161919.18117.51612.stgit@localhost.localdomain>

On Fri, 02 Jan 2009 16:19:23 +0000
Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:

Hi! I bet, it does not pass checkpatch (tabs to spaces clash)
Sorry, can't send fixed patch.

> From: Federico Heinz <fheinz@vialibre.org.ar>
> 
> This trivial patch adds support for i8k on the new Dell Vostro models.
> I tested it on my Vostro 1400, and it works. It does print a warning
> when loading the module:
> 
> 	i8k: unable to get SMM BIOS version
> 
> But I couldn't figure out how to fix that. The module seems to work fine,
> anyway...
> 
> Signed-off-by: Federico Heinz <fheinz@vialibre.org.ar>
> Signed-off-by: Alan Cox <alan@redhat.com>
> ---
> 
>  drivers/char/i8k.c |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)
> 
> 
> diff --git a/drivers/char/i8k.c b/drivers/char/i8k.c
> index 099fc89..fc8cf7a 100644
> --- a/drivers/char/i8k.c
> +++ b/drivers/char/i8k.c

...
> -	{ }
^^^^^^
This one
vvvvvvv
> +        { }
>  };

-- 

  Sergei

      reply	other threads:[~2009-01-02 17:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-02 16:18 [PATCH 0/2] Series short description Alan Cox
2009-01-02 16:19 ` [PATCH 1/2] i8k: Enable i8k on Dell Precision Systems Alan Cox
2009-01-02 16:19 ` [PATCH 2/2] i8k: Add Dell Vostro systems Alan Cox
2009-01-02 16:45   ` Sergei Trofimovich [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090102184522.07bc2b86@slyfox.slynet.org \
    --to=slyfox@uvaga.by \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome