From: Ingo Molnar <mingo@elte.hu>
To: Roland Dreier <rdreier@cisco.com>
Cc: Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org,
Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>
Subject: Re: swiotlb: Add missing __init annotations
Date: Fri, 2 Jan 2009 21:46:49 +0100 [thread overview]
Message-ID: <20090102204649.GB21988@elte.hu> (raw)
In-Reply-To: <adasko1pjck.fsf@cisco.com>
* Roland Dreier <rdreier@cisco.com> wrote:
> > > @@ -186,7 +186,7 @@ static void swiotlb_print_info(unsigned long bytes)
> > > * Statically reserve bounce buffer space and initialize bounce buffer data
> > > * structures for the software IO TLB used to implement the DMA API.
> > > */
> > > -void __init
> > > +void __init __weak
> > > swiotlb_init_with_default_size(size_t default_size)
> >
> > This change looks unrealted to __init annotation described in the
> > changelog. Was it intentional?
>
> Yes, that was a thinko -- somehow while reading it I saw the __init
> without __weak as being missing an annotation. Should I resend a fixed
> patch?
no need - so it wasnt needed to make a section warning go away - i.e. your
patch sans the last hunk is tested to solve the problem, right?
Ingo
next prev parent reply other threads:[~2009-01-02 20:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-31 4:18 Roland Dreier
2009-01-01 13:02 ` Sam Ravnborg
2009-01-02 19:25 ` Ingo Molnar
2009-01-02 20:02 ` Roland Dreier
2009-01-02 20:46 ` Ingo Molnar [this message]
2009-01-02 22:36 ` Roland Dreier
2009-01-02 22:42 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090102204649.GB21988@elte.hu \
--to=mingo@elte.hu \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=jeremy.fitzhardinge@citrix.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdreier@cisco.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®