From: Ingo Molnar <mingo@elte.hu>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Mike Travis <travis@sgi.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] cpumask: convert RCU implementations, fix
Date: Sat, 3 Jan 2009 13:19:39 +0100 [thread overview]
Message-ID: <20090103121939.GA15006@elte.hu> (raw)
In-Reply-To: <20090103115904.GA440@elte.hu>
there's a build warning regression as well on CONFIG_RCU_CLASSIC:
kernel/rcuclassic.c: In function ‘rcu_start_batch’:
kernel/rcuclassic.c:397: warning: passing argument 1 of ‘cpumask_andnot’ from incompatible pointer type
caused by:
bd232f9: cpumask: convert RCU implementations
fixed via the patch below. (i'll carry this in cpus4096 too, ok?)
Ingo
---------------------->
>From 9caab32c0d69e569e33caa03845cec73ae701f32 Mon Sep 17 00:00:00 2001
From: Ingo Molnar <mingo@elte.hu>
Date: Sat, 3 Jan 2009 13:16:09 +0100
Subject: [PATCH] cpumask: convert RCU implementations, fix
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Impact: cleanup
This warning:
kernel/rcuclassic.c: In function ‘rcu_start_batch’:
kernel/rcuclassic.c:397: warning: passing argument 1 of ‘cpumask_andnot’ from incompatible pointer type
triggers because one usage site of rcp->cpumask was not converted
to to_cpumask(rcp->cpumask). There's no ill effects of this bug.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
kernel/rcuclassic.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/rcuclassic.c b/kernel/rcuclassic.c
index 6ec495f..490934f 100644
--- a/kernel/rcuclassic.c
+++ b/kernel/rcuclassic.c
@@ -394,7 +394,8 @@ static void rcu_start_batch(struct rcu_ctrlblk *rcp)
* unnecessarily.
*/
smp_mb();
- cpumask_andnot(&rcp->cpumask, cpu_online_mask, nohz_cpu_mask);
+ cpumask_andnot(to_cpumask(rcp->cpumask),
+ cpu_online_mask, nohz_cpu_mask);
rcp->signaled = 0;
}
next prev parent reply other threads:[~2009-01-03 12:20 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-01 1:19 [PULL] cpumask tree Rusty Russell
2009-01-02 20:06 ` Linus Torvalds
2009-01-02 20:38 ` Ingo Molnar
2009-01-02 23:31 ` Linus Torvalds
2009-01-03 19:38 ` [git pull] cpus4096 tree, part 3 Ingo Molnar
2009-01-03 20:28 ` Linus Torvalds
2009-01-03 20:36 ` Ingo Molnar
2009-01-03 20:56 ` Linus Torvalds
2009-01-03 21:58 ` Ingo Molnar
2009-01-04 3:35 ` Rusty Russell
2009-01-04 4:28 ` Mike Travis
2009-01-03 21:38 ` Ingo Molnar
2009-01-03 22:00 ` Linus Torvalds
2009-01-03 22:37 ` Ingo Molnar
2009-01-05 1:14 ` Nick Piggin
2009-01-05 1:16 ` Nick Piggin
2009-01-26 19:00 ` Andrew Morton
2009-01-26 19:09 ` Linus Torvalds
2009-01-26 19:30 ` Andrew Morton
2009-01-26 20:09 ` Ingo Molnar
2009-01-26 20:44 ` Andrew Morton
[not found] ` <604427e00901261312w23a1f0f5y61fc5c6cc70297fb@mail.gmail.com>
2009-01-26 23:21 ` Ingo Molnar
2009-01-26 23:44 ` Andrew Morton
2009-01-07 17:30 ` Ingo Molnar
2009-01-03 20:58 ` Mike Travis
2009-01-03 7:20 ` [PULL] cpumask tree Rusty Russell
2009-01-03 10:52 ` Ingo Molnar
2009-01-03 11:59 ` [PATCH] ia64: cpumask fix for is_affinity_mask_valid() Ingo Molnar
2009-01-03 12:19 ` Ingo Molnar [this message]
2009-01-04 3:43 ` Rusty Russell
2009-01-04 4:20 ` Mike Travis
2009-01-04 12:38 ` Ingo Molnar
2009-01-03 14:58 ` [PULL] cpumask tree Mike Travis
2009-01-03 15:06 ` Ingo Molnar
2009-01-03 15:31 ` Mike Travis
2009-01-03 15:47 ` Ingo Molnar
2009-01-03 15:52 ` Mike Travis
2009-01-03 16:00 ` Ingo Molnar
2009-01-03 16:09 ` Mike Travis
2009-01-03 16:42 ` Ingo Molnar
2009-01-03 16:48 ` Mike Travis
2009-01-03 17:45 ` Ingo Molnar
2009-01-03 18:13 ` Ingo Molnar
2009-01-03 18:14 ` Mike Travis
2009-01-03 0:23 ` Rusty Russell
2009-01-08 19:10 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090103121939.GA15006@elte.hu \
--to=mingo@elte.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@linux-foundation.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®