From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Milton Miller <miltonm@bga.com>
Cc: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
linux-ppc <linuxppc-dev@ozlabs.org>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH
Date: Sun, 4 Jan 2009 23:12:02 +1100 [thread overview]
Message-ID: <20090104231202.239c824a.sfr@canb.auug.org.au> (raw)
In-Reply-To: <5414eaef99b7392a95f6e3488b81dbf7@bga.com>
[-- Attachment #1: Type: text/plain, Size: 1095 bytes --]
Hi Milton,
On Sun, 4 Jan 2009 02:54:15 -0600 Milton Miller <miltonm@bga.com> wrote:
>
> As VIOPATH is iSeries code and is only used by the iSeries code, the
> requirment should be
>
> depends on PPC_PSERIES || (PPC_ISERIES && VIOPATH)
>
> except VIOPATH isn't selectable:
>
> arch/powerpc/platforms/iseries/Kconfig:
>
> config VIOPATH
> bool
> depends on VIODASD || VIOCD || VIOTAPE || ISERIES_VETH
> default y
>
> so instead we should be adding
>
> select VIOPATH if PPC_ISERIES
>
> to SCSI_IBMVSCSI and just
>
> select VIOPATH
>
> to HVC_ISERIES as it depends on PPC_ISERIES
>
> otherwise you have to enable one driver to get these other drivers.
You are completely correct. We didn't have "select" when those drivers
were added (at least I was not aware of it) so they should all be changed
to select VIOPATH and the dependency in VIOPATH should be dropped. This sort of thing is exactly what select is for.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-01-04 12:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 8:54 Milton Miller
2009-01-04 12:12 ` Stephen Rothwell [this message]
2009-01-04 18:24 ` Kamalesh Babulal
2009-01-05 13:33 ` Milton Miller
2009-01-06 7:25 ` Kamalesh Babulal
2009-01-06 7:31 ` Sam Ravnborg
2009-01-06 9:38 ` Kamalesh Babulal
2009-01-06 10:46 ` Sam Ravnborg
2009-01-06 15:57 ` Kamalesh Babulal
2009-01-06 16:40 ` Sam Ravnborg
-- strict thread matches above, loose matches on Subject: below --
2009-01-03 19:13 Kamalesh Babulal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090104231202.239c824a.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=kamalesh@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®