From: Ingo Molnar <mingo@elte.hu>
To: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>
Cc: linux-kernel@vger.kernel.org, dhaval@linux.vnet.ibm.com,
jens.axboe@oracle.com, snakebyte@gmx.de, andi@firstfloor.org,
akpm@linux-foundation.org, dvhltc@us.ibm.com, niv@us.ibm.com,
rostedt@goodmis.org, tglx@linutronix.de,
manfred@colorfullife.com
Subject: Re: [PATCH] Make treercu safe for suspend and resume
Date: Mon, 5 Jan 2009 10:12:50 +0100 [thread overview]
Message-ID: <20090105091249.GB5440@elte.hu> (raw)
In-Reply-To: <20090104194111.GA16398@linux.vnet.ibm.com>
* Paul E. McKenney <paulmck@linux.vnet.ibm.com> wrote:
> Hello!
>
> Kudos to both Dhaval Giani and Jens Axboe for finding a bug in treercu
> that causes warnings after suspend-resume cycles in Dhaval's case and
> during stress tests in Jens's case. It would also probably cause failures
> if heavily stressed. The solution, ironically enough, is to revert to
> rcupreempt's code for initializing the dynticks state. And the patch
> even results in smaller code -- so what was I thinking???
>
> This is 2.6.29 material, given that people really do suspend and resume
> Linux these days. ;-)
>
> Located-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
> Located-by: Jens Axboe <jens.axboe@oracle.com>
> Tested-by: Dhaval Giani <dhaval@linux.vnet.ibm.com>
> Tested-by: Jens Axboe <jens.axboe@oracle.com>
> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> ---
>
> rcutree.c | 12 ++++--------
> 1 file changed, 4 insertions(+), 8 deletions(-)
applied to tip/core/urgent, thanks guys!
Ingo
prev parent reply other threads:[~2009-01-05 9:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-04 19:41 Paul E. McKenney
2009-01-04 20:41 ` Eric Sesterhenn
2009-01-04 21:14 ` Paul E. McKenney
2009-01-05 9:12 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090105091249.GB5440@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=dhaval@linux.vnet.ibm.com \
--cc=dvhltc@us.ibm.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=niv@us.ibm.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=rostedt@goodmis.org \
--cc=snakebyte@gmx.de \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®