From: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: Pavel Machek <pavel@suse.cz>,
linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH] pci-quirks: HP hides SMBus controller in Compaq nx9500 laptops
Date: Mon, 5 Jan 2009 21:02:21 +0100 [thread overview]
Message-ID: <20090105200221.GA26115@rere.qmqm.pl> (raw)
In-Reply-To: <200901051119.20684.jbarnes@virtuousgeek.org>
On Mon, Jan 05, 2009 at 11:19:20AM -0800, Jesse Barnes wrote:
> On Wednesday, December 31, 1969 10:46 pm Pavel Machek wrote:
> > On Tue 2008-12-23 22:54:07, Micha? Miros?aw wrote:
> > > I found no references to SMBus in ACPI DSDT disassembly on my laptop
> > > so this should be safe.
> > >
> > > Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> > Well, it could still be used by smm bios traps...
> Also, the changelog doesn't include a description of what this patch fixes, if
> anything. Care to resend with an explanation Michal?
This patch enables SMBus controller on HP Compaq nx9500 laptop and
allowes to read SPD EEPROMs of the memory modules.
I found no references to SMBus in ACPI DSDT disassembly on my laptop, but
there are some additional devices on the bus (besides SPD chips).
rechot ~ # lspci -s 00:1f.3
00:1f.3 SMBus: Intel Corporation 82801EB/ER (ICH5/ICH5R) SMBus Controller (rev 02)
rechot ~ # i2cdetect -a 0
WARNING! This program can confuse your I2C bus, cause data loss and worse!
I will probe file /dev/i2c-0.
I will probe address range 0x00-0x7f.
Continue? [Y/n] y
0 1 2 3 4 5 6 7 8 9 a b c d e f
00: -- -- -- -- -- -- -- -- 08 -- -- -- -- -- -- --
10: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
20: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
30: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
40: -- -- -- -- 44 -- -- -- -- -- -- -- -- -- -- --
50: 50 -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
60: -- -- -- -- -- -- -- -- -- 69 -- -- -- -- -- --
70: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
I observed no ill effects after scanning the bus, but YMMV.
Using the bus is probably not a good idea if the SMM code is really using
it, and so it might be better if this patch lies in the archives for now.
After I get the BIOS flashing to work I'll look into this.
Best Regards,
Michal Miroslaw
next prev parent reply other threads:[~2009-01-05 20:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-23 21:54 Michał Mirosław
1970-01-01 6:46 ` Pavel Machek
2009-01-05 19:19 ` Jesse Barnes
2009-01-05 20:02 ` Michał Mirosław [this message]
2009-01-06 8:41 ` Pavel Machek
2009-01-06 12:43 ` Michał Mirosław
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090105200221.GA26115@rere.qmqm.pl \
--to=mirq-linux@rere.qmqm.pl \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®