mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mike Travis <travis@sgi.com>
To: Ingo Molnar <mingo@redhat.com>, Rusty Russell <rusty@rustcorp.com.au>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>, Jack Steiner <steiner@sgi.com>,
	linux-kernel@vger.kernel.org,
	Ben Hutchings <bhutchings@solarflare.com>,
	linux-net-drivers@solarflare.com
Subject: [PATCH 4/5] cpumask: convert drivers/net/sfc
Date: Wed, 07 Jan 2009 11:58:36 -0800	[thread overview]
Message-ID: <20090107195832.871689000@polaris-admin.engr.sgi.com> (raw)
In-Reply-To: <20090107195832.265117000@polaris-admin.engr.sgi.com>

[-- Attachment #1: cpumask:convert-drivers_net_sfc_efx.c.patch --]
[-- Type: text/plain, Size: 1390 bytes --]

From: Rusty Russell <rusty@rustcorp.com.au>

Impact: reduce stack usage, use new cpumask API.

Remove a cpumask from the stack.  Ben Hutchings indicated that printing
a warning and returning 1 was acceptable for the corner case where allocation
fails.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Mike Travis <travis@sgi.com>
Cc: Ben Hutchings <bhutchings@solarflare.com>
Cc: linux-net-drivers@solarflare.com
---
 drivers/net/sfc/efx.c |   15 +++++++++++----
 1 file changed, 11 insertions(+), 4 deletions(-)

diff --git a/drivers/net/sfc/efx.c b/drivers/net/sfc/efx.c
--- a/drivers/net/sfc/efx.c
+++ b/drivers/net/sfc/efx.c
@@ -854,20 +854,27 @@ static void efx_fini_io(struct efx_nic *
  * interrupts across them. */
 static int efx_wanted_rx_queues(void)
 {
-	cpumask_t core_mask;
+	cpumask_var_t core_mask;
 	int count;
 	int cpu;
 
-	cpus_clear(core_mask);
+	if (!alloc_cpumask_var(&core_mask, GFP_KERNEL)) {
+		printk(KERN_WARNING
+		       "efx.c: allocation failure, irq balancing hobbled\n");
+		return 1;
+	}
+
+	cpumask_clear(core_mask);
 	count = 0;
 	for_each_online_cpu(cpu) {
-		if (!cpu_isset(cpu, core_mask)) {
+		if (!cpumask_test_cpu(cpu, core_mask)) {
 			++count;
-			cpumask_or(&core_mask, &core_mask,
+			cpumask_or(core_mask, core_mask,
 				   topology_core_cpumask(cpu));
 		}
 	}
 
+	free_cpumask_var(core_mask);
 	return count;
 }
 

-- 

  parent reply	other threads:[~2009-01-07 19:59 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07 19:58 [PATCH 0/5] cpumask: more cpumask updates Mike Travis
2009-01-07 19:58 ` [PATCH 1/5] cpumask: update irq_desc to use cpumask_var_t Mike Travis
2009-01-07 20:27   ` Yinghai Lu
2009-01-07 22:32     ` Mike Travis
2009-01-08  3:15       ` Yinghai Lu
2009-01-08 15:45         ` Mike Travis
2009-01-08 19:31           ` Yinghai Lu
2009-01-08 18:40         ` [PATCH 1/5] cpumask: update irq_desc to use cpumask_var_t: fix Mike Travis
2009-01-07 19:58 ` [PATCH 2/5] cpumask: Use topology_core_cpumask()/topology_thread_cpumask() Mike Travis
2009-01-19 17:11   ` Ben Hutchings
2009-01-07 19:58 ` [PATCH 3/5] cpumask: convert misc driver functions Mike Travis
2009-01-10 10:57   ` Rusty Russell
2009-01-16 18:42   ` Tony Luck
2009-01-16 18:55     ` Mike Travis
2009-01-16 22:02     ` Mike Travis
2009-01-22 13:11   ` Robert Richter
2009-01-22 13:14     ` [PATCH] cpumask: modifiy oprofile initialization Robert Richter
2009-01-22 13:37       ` Ingo Molnar
2009-01-22 17:20         ` Mike Travis
2009-01-22 17:40           ` Ingo Molnar
2009-01-22 19:41         ` Mike Travis
2009-01-22 16:56       ` Mike Travis
2009-01-23 14:12         ` Robert Richter
2009-01-07 19:58 ` Mike Travis [this message]
2009-01-19 17:08   ` [PATCH 4/5] cpumask: convert drivers/net/sfc Ben Hutchings
     [not found]     ` <200901201209.34854.rusty@rustcorp.com.au>
2009-01-20 18:26       ` [PATCH 4/5] cpumask: convert drivers/net/sfc [PATCH supplied] Mike Travis
2009-01-26 15:04       ` [PATCH] sfc: modify allocation error message Mike Travis
2009-01-27 12:13         ` Ben Hutchings
2009-01-07 19:58 ` [PATCH 5/5] cpumask: convert other misc kernel functions Mike Travis
2009-01-07 20:52 ` [PATCH 0/5] cpumask: more cpumask updates Ingo Molnar
2009-01-07 21:20   ` Mike Travis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090107195832.871689000@polaris-admin.engr.sgi.com \
    --to=travis@sgi.com \
    --cc=bhutchings@solarflare.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net-drivers@solarflare.com \
    --cc=mingo@redhat.com \
    --cc=rusty@rustcorp.com.au \
    --cc=steiner@sgi.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®