From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762329AbZAHTa2 (ORCPT ); Thu, 8 Jan 2009 14:30:28 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751946AbZAHTaJ (ORCPT ); Thu, 8 Jan 2009 14:30:09 -0500 Received: from 74-93-104-97-Washington.hfc.comcastbusiness.net ([74.93.104.97]:49943 "EHLO sunset.davemloft.net" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751763AbZAHTaH (ORCPT ); Thu, 8 Jan 2009 14:30:07 -0500 Date: Thu, 08 Jan 2009 11:30:09 -0800 (PST) Message-Id: <20090108.113009.263402475.davem@davemloft.net> To: vapier.adi@gmail.com Cc: cooloney@kernel.org, jeff@garzik.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, graf.yang@analog.com Subject: Re: [PATCH 2/2] netdev: bfin_mac: enable VLAN support in Blackfin MAC driver From: David Miller In-Reply-To: <8bd0f97a0901081105q1e897254kad9a8533b5845403@mail.gmail.com> References: <20090108.105531.176161465.davem@davemloft.net> <8bd0f97a0901081101t6fdfa485rbd7ccc4e47691ddb@mail.gmail.com> <8bd0f97a0901081105q1e897254kad9a8533b5845403@mail.gmail.com> X-Mailer: Mew version 6.1 on Emacs 22.1 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: "Mike Frysinger" Date: Thu, 8 Jan 2009 14:05:33 -0500 > On Thu, Jan 8, 2009 at 14:01, Mike Frysinger wrote: > > On Thu, Jan 8, 2009 at 13:55, David Miller wrote: > >> We can get VLAN packets received and sent, using AF_PACKET > >> sockets, for example. The chip should still respect those > >> even if VLAN proper is not being utilized. > > > > any tips on doing that ? > > or rather, is there a driver or you two you can point out that is > doing this correctly ? the ones i looked at seemed to be doing it > like the patch we posted ... And I disagree with how those drivers are doing it :-) At least the programming of the chip to accept all packet types properly, VLAN or not, regardless of kernel config, is definitely IMHO the way to go.