Re: [Regression] hald segfaults at startup on Toshiba Portege R500 x86_64 (bisected)

["Rafael J. Wysocki" <rjw@sisk.pl>]

On Thursday 08 January 2009, Pierre Ossman wrote:
> On Thu, 8 Jan 2009 08:27:02 +0100
> "Rafael J. Wysocki" <rjw@sisk.pl> wrote:
> 
> > Hi,
> > 
> > Unfortunately the following commit:
> > 
> > commit 35ff8554d12ecc80a46ea0d9bce34fe28733ff38
> > Author: Éric Piel <eric.piel@tremplin-utc.net>
> > Date:   Sat Nov 22 19:29:29 2008 +0100
> > 
> >     sdhci: activate led support also when module
> > 
> >     CONFIG_LEDS_CLASS is defined only if led-class is built-in, otherwise
> >     when it is a module the option is called CONFIG_LEDS_CLASS_MODULE. Led
> >     support should also be activated in this case.
> > 
> >     Signed-off-by: Eric Piel <eric.piel@tremplin-utc.net>
> >     Signed-off-by: Pierre Ossman <drzeus@drzeus.cx>
> > 
> > causes hald to segfault at startup (not always, but sufficiently often for
> > bisection) on my Toshiba Portege R500 w/ x86_64 kernel/userland.
> > 
> 
> I have trouble seeing a user space application crashing as a kernel
> bug. Do you have a backtrace or strace of hald to see exactly where it
> crashes?

No, I don't.  I'll try to get one later.

> > While it doesn't revert cleanly, I have applied the appended patch (which is
> > a revert of the commit above) and hald doesn't segfault any more here.
> > 
> 
> Is CONFIG_LEDS_CLASS defined in your config, or are you essentially
> turning of the LED functionality?

I have CONFIG_LEDS_CLASS=m (so I guess the patch just makes the led support
in sdhci active).

Thanks,
Rafael