From: David Miller <davem@davemloft.net>
To: alexey.zaytsev@gmail.com
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, rostedt@goodmis.org
Subject: Re: [PATCH] Disable branch profiling macros when sparsed.
Date: Fri, 09 Jan 2009 22:13:48 -0800 (PST) [thread overview]
Message-ID: <20090109.221348.166902734.davem@davemloft.net> (raw)
In-Reply-To: <20090110052727.5471.3654.stgit@zaytsev.su>
From: Alexey Zaytsev <alexey.zaytsev@gmail.com>
Date: Sat, 10 Jan 2009 08:57:28 +0300
> The macros produce lots of unneeded warnings when
> recursive if(({ .. if() {..} ..})) {..} and such
> are substituted. And there is no point in sparsing
> them anyway. This is useful if someone decides to
> sparse an allyesconfig kernel.
>
> Signed-off-by: Alexey Zaytsev <alexey.zaytsev@gmail.com>
If even sparse can't handle these things, it's no surprise
how many gcc bogus warning problems we've run into because
of this hairy if() macro.
I don't think it's a good precedence to do this. It's giving
up on trying to implement the branch tracer in a way that
results in a kernel build that produces useful warnings.
next prev parent reply other threads:[~2009-01-10 6:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-10 5:57 Alexey Zaytsev
2009-01-10 6:13 ` David Miller [this message]
2009-01-10 7:18 ` Harvey Harrison
2009-01-10 9:35 ` Alexey Zaytsev
2009-01-10 21:33 ` Harvey Harrison
2009-01-10 23:04 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109.221348.166902734.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexey.zaytsev@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome