From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: Zdenek Kabelac <zdenek.kabelac@gmail.com>,
Tejun Heo <tj@kernel.org>,
"Justin P. Mattock" <justinmattock@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jeff Garzik <jgarzik@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Arjan van de Ven <arjan@infradead.org>
Subject: Re: [PATCH] libata: use WARN_ON_ONCE on hot paths
Date: Fri, 9 Jan 2009 12:07:30 +0000 [thread overview]
Message-ID: <20090109120730.5c80fc68@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <49673D02.6000002@garzik.org>
> If I had to guess, I would say that Arjan's patches assume it is OK to
> treat two ports on a single IDE controller as completely independent,
> when that is not really the reality of the hardware.
The PCI probe paths and the setup paths of several of the PATA
controller drivers know they are single threaded in a few spots so it
wouldn't suprise me in the slightest. Really this async stuff needs to
spend 2 or 3 months in -next getting the kinks worked out so that driver
assumptions can be pinned down and fixed, and someone can give it an API
with names that anyone but Arjan understands ;)
Alan
next prev parent reply other threads:[~2009-01-09 12:08 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 20:02 Too async libata breakage Alexey Dobriyan
2009-01-08 20:17 ` Pekka Paalanen
2009-01-08 20:53 ` [fix] " Arjan van de Ven
2009-01-08 21:22 ` Justin P. Mattock
2009-01-08 22:20 ` Justin P. Mattock
2009-01-08 22:31 ` Arjan van de Ven
2009-01-08 23:26 ` Justin P. Mattock
2009-01-09 0:16 ` Justin P. Mattock
2009-01-09 0:23 ` Linus Torvalds
2009-01-09 0:33 ` Justin P. Mattock
2009-01-09 10:05 ` Justin P. Mattock
2009-01-09 10:10 ` Tejun Heo
2009-01-09 10:19 ` [PATCH] libata: use WARN_ON_ONCE on hot paths Tejun Heo
2009-01-09 11:31 ` Zdenek Kabelac
2009-01-09 12:03 ` Jeff Garzik
2009-01-09 12:07 ` Alan Cox [this message]
2009-01-09 17:10 ` Justin P. Mattock
2009-01-09 18:39 ` Justin P. Mattock
2009-01-11 19:58 ` Zdenek Kabelac
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109120730.5c80fc68@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=arjan@infradead.org \
--cc=jeff@garzik.org \
--cc=jgarzik@redhat.com \
--cc=justinmattock@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=zdenek.kabelac@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®