From: David Howells <dhowells@redhat.com>
To: torvalds@osdl.org, jmorris@namei.org, akpm@linux-foundation.org
Cc: dhowells@redhat.com, steved@redhat.com,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org
Subject: [PATCH 1/2] CRED: Missing put_cred() in prepare_kernel_cred()
Date: Fri, 09 Jan 2009 16:13:41 +0000 [thread overview]
Message-ID: <20090109161341.13371.24540.stgit@warthog.procyon.org.uk> (raw)
Missing put_cred() in the error handling path of prepare_kernel_cred().
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Steve Dickson <steved@redhat.com>
---
kernel/cred.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/cred.c b/kernel/cred.c
index 480a61a..400e608 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -530,6 +530,7 @@ struct cred *prepare_kernel_cred(struct task_struct *daemon)
error:
put_cred(new);
+ put_cred(old);
return NULL;
}
EXPORT_SYMBOL(prepare_kernel_cred);
next reply other threads:[~2009-01-09 16:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 16:13 David Howells [this message]
2009-01-09 16:13 ` [PATCH 2/2] CRED: Must initialise the new creds " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109161341.13371.24540.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=steved@redhat.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®