From: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Paul Menage <menage@google.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [RFC][PATCH] NOOP cgroup subsystem
Date: Fri, 9 Jan 2009 16:22:55 +0900 [thread overview]
Message-ID: <20090109162255.4e57f079.kamezawa.hiroyu@jp.fujitsu.com> (raw)
In-Reply-To: <4966F230.4020905@cn.fujitsu.com>
On Fri, 09 Jan 2009 14:44:00 +0800
Li Zefan <lizf@cn.fujitsu.com> wrote:
> Paul Menage wrote:
> > On Thu, Jan 8, 2009 at 10:29 PM, Li Zefan <lizf@cn.fujitsu.com> wrote:
> >> Agreed, but it can't work by just removing the checking in cgroup mount option,
> >
> > Right - it's more complicated than that. There are some places in the
> > code that rely on the fact that every hierarchy currently has at least
> > one subsystem (anything that uses find_first_subsystem() for example)
> > and we'd need to work around that.
> >
>
> And some other problems, like what's the semantic of /proc/<pid>/cgroup when
> using none subsys.
>
> I'm afraid even if it's do-able it might require a lot of changes in cgroup.
>
After quick look,
it seems that css_set->subsys==empty case cannot be handled and need much
changes. Maintaining hierarchy tree itself seems difficult.
I think cgroup is being stable day by day. So, I don't like to crash it
by big hummer for this tiny feature.
How about adding "none" subsys ? (I'd like to set default=y ;)
As Paul said, "Show multiple hierarchy view for each mount point"
seems attractive but it's not very fundametal, IMHO.
If we can increase subsys_id dynamically or subsys can have
multiple root node, the situation will change.
Thanks,
-Kame
next prev parent reply other threads:[~2009-01-09 7:24 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 5:32 KAMEZAWA Hiroyuki
2009-01-09 6:14 ` Li Zefan
2009-01-09 6:24 ` KAMEZAWA Hiroyuki
2009-01-09 6:27 ` Paul Menage
2009-01-09 6:26 ` Paul Menage
2009-01-09 6:29 ` Li Zefan
2009-01-09 6:37 ` Paul Menage
2009-01-09 6:44 ` Li Zefan
2009-01-09 7:22 ` KAMEZAWA Hiroyuki [this message]
2009-01-09 21:15 ` Paul Menage
2009-01-09 6:32 ` KAMEZAWA Hiroyuki
2009-01-16 2:20 ` Matthew Helsley
2009-01-16 2:45 ` KAMEZAWA Hiroyuki
2009-01-16 3:02 ` KAMEZAWA Hiroyuki
2009-01-20 1:52 ` Paul Menage
2009-01-20 3:07 ` KAMEZAWA Hiroyuki
2009-01-21 2:36 ` Matt Helsley
2009-01-21 3:16 ` Paul Menage
2009-01-09 6:34 ` Daisuke Nishimura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109162255.4e57f079.kamezawa.hiroyu@jp.fujitsu.com \
--to=kamezawa.hiroyu@jp.fujitsu.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®