From: Alexey Zaytsev <alexey.zaytsev@gmail.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Jiri Kosina <jkosina@suse.cz>,
Trivial Kernel Patches <trivial@kernel.org>
Subject: [PATCH 3/5] Fix dubious bitwise 'and' usage spotted by sparse.
Date: Sat, 10 Jan 2009 02:48:13 +0300 [thread overview]
Message-ID: <20090109234813.11800.84518.stgit@zaytsev.su> (raw)
In-Reply-To: <20090109234113.11800.55672.stgit@zaytsev.su>
It doesn't change the semantics, but it looks like
the logical 'and' was meant to be used here.
---
drivers/media/video/gspca/m5602/m5602_s5k4aa.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/gspca/m5602/m5602_s5k4aa.c b/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
index 14b1eac..c3ebcca 100644
--- a/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
+++ b/drivers/media/video/gspca/m5602/m5602_s5k4aa.c
@@ -114,7 +114,7 @@ int s5k4aa_read_sensor(struct sd *sd, const u8 address,
if (err < 0)
goto out;
- for (i = 0; (i < len) & !err; i++) {
+ for (i = 0; (i < len) && !err; i++) {
err = m5602_read_bridge(sd, M5602_XB_I2C_DATA, &(i2c_data[i]));
PDEBUG(D_CONF, "Reading sensor register "
next prev parent reply other threads:[~2009-01-09 23:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 23:47 [PATCH 0/5] [trivial] Fix dubious bitwise and/or usage Alexey Zaytsev
2009-01-09 23:47 ` [PATCH 1/5] Fix dubious bitwise 'or' usage spotted by sparse Alexey Zaytsev
2009-01-09 23:48 ` [PATCH 2/5] " Alexey Zaytsev
2009-01-09 23:48 ` Alexey Zaytsev [this message]
2009-01-09 23:56 ` [PATCH 3/5] Fix dubious bitwise 'and' " Jiri Kosina
2009-01-09 23:48 ` [PATCH 4/5] " Alexey Zaytsev
2009-01-09 23:58 ` Jiri Kosina
2009-01-09 23:48 ` [PATCH 5/5] " Alexey Zaytsev
2009-01-10 9:47 ` Tom Spink
2009-01-10 0:00 ` [PATCH 0/5] [trivial] Fix dubious bitwise and/or usage Jiri Kosina
2009-01-10 1:28 ` Alexey Zaytsev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090109234813.11800.84518.stgit@zaytsev.su \
--to=alexey.zaytsev@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®