From: David Miller <davem@davemloft.net>
To: sfr@canb.auug.org.au
Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org,
travis@sgi.com, mingo@elte.hu
Subject: Re: cpumask change causes sparc build bustage
Date: Sun, 11 Jan 2009 04:06:40 -0800 (PST) [thread overview]
Message-ID: <20090111.040640.188129980.davem@davemloft.net> (raw)
In-Reply-To: <20090111205008.db0a410e.sfr@canb.auug.org.au>
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Sun, 11 Jan 2009 20:50:08 +1100
> On Sun, 11 Jan 2009 00:31:03 -0800 (PST) David Miller <davem@davemloft.net> wrote:
> >
> > I'm surprised linux-next builds didn't catch this.
>
> So am I. http://kisskb.ellerman.id.au/kisskb/compiler/5/ shows my latest
> builds of both linux-next and Linus' tree are OK for defconfig and
> allnoconfig (allmodconfig fails for a different reason).
>
> What is different about the failing config (compiler)? Are there other
> configs it would be sensible to build test?
Maybe you don't have NUMA enabled in the test build configs.
I hit it during an allmodconfig.
Anyways this fixes it, someone please apply:
sparc64: Fix cpumask related build failure.
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/arch/sparc/include/asm/topology_64.h b/arch/sparc/include/asm/topology_64.h
index b8a65b6..5bc0b8f 100644
--- a/arch/sparc/include/asm/topology_64.h
+++ b/arch/sparc/include/asm/topology_64.h
@@ -47,6 +47,10 @@ static inline int pcibus_to_node(struct pci_bus *pbus)
(pcibus_to_node(bus) == -1 ? \
CPU_MASK_ALL : \
node_to_cpumask(pcibus_to_node(bus)))
+#define cpumask_of_pcibus(bus) \
+ (pcibus_to_node(bus) == -1 ? \
+ CPU_MASK_ALL_PTR : \
+ cpumask_of_node(pcibus_to_node(bus)))
#define SD_NODE_INIT (struct sched_domain) { \
.min_interval = 8, \
next prev parent reply other threads:[~2009-01-11 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 8:31 David Miller
2009-01-11 9:50 ` Stephen Rothwell
2009-01-11 12:06 ` David Miller [this message]
2009-01-11 12:13 ` Ingo Molnar
2009-01-11 16:49 ` Mike Travis
2009-01-11 21:50 ` David Miller
2009-01-11 22:29 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090111.040640.188129980.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
--cc=travis@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®