From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Matt Mackall <mpm@selenic.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] sparseirq: make some func to be used with genirq
Date: Sun, 11 Jan 2009 15:54:06 +0100 [thread overview]
Message-ID: <20090111145406.GB13453@elte.hu> (raw)
In-Reply-To: <4969AF5E.7020809@kernel.org>
* Yinghai Lu <yinghai@kernel.org> wrote:
> Ingo Molnar wrote:
> > Yinghai, the crossbuild to Alpha fails with:
> >
> > /home/mingo/tip/kernel/fork.c: In function 'copy_signal':
> > /home/mingo/tip/kernel/fork.c:825: warning: unused variable 'ret'
> > /home/mingo/tip/drivers/char/random.c: In function 'get_timer_rand_state':
> > /home/mingo/tip/drivers/char/random.c:584: error: dereferencing pointer to incomplete type
> > /home/mingo/tip/drivers/char/random.c: In function 'set_timer_rand_state':
> > /home/mingo/tip/drivers/char/random.c:594: error: dereferencing pointer to incomplete type
> > make[3]: *** [drivers/char/random.o] Error 1
> >
>
> please check
>
> [PATCH] sparseirq: fix compiling with unknown irq_desc struct
>
> Impact: fix compiling
>
> irq_desc is defined in linux/irq.h
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> diff --git a/include/linux/random.h b/include/linux/random.h
> index 407ea36..a27bf17 100644
> --- a/include/linux/random.h
> +++ b/include/linux/random.h
> @@ -10,6 +10,10 @@
> #include <linux/ioctl.h>
> #include <linux/irqnr.h>
>
> +#ifdef CONFIG_GENERIC_HARDIRQS
> +#include <linux/irq.h>
> +#endif
applied to tip/irq/sparseirq, thanks Yinghai!
Ingo
next prev parent reply other threads:[~2009-01-11 14:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 23:03 Yinghai Lu
2009-01-08 12:06 ` Ingo Molnar
2009-01-08 17:17 ` Matt Mackall
2009-01-11 3:46 ` Ingo Molnar
2009-01-11 3:59 ` Mike Travis
2009-01-11 4:05 ` Ingo Molnar
2009-01-11 4:18 ` Mike Travis
2009-01-11 4:28 ` Ingo Molnar
2009-01-11 8:35 ` Yinghai Lu
2009-01-11 14:54 ` Ingo Molnar [this message]
2009-01-11 15:04 ` Ingo Molnar
2009-01-11 15:07 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090111145406.GB13453@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®