* Ingo Molnar wrote: > > * Yinghai Lu wrote: > > > Impact: clean up > > > > it seems Ingo revert it wrongly. > > put it back again > > > > Signed-off-by: Yinghai Lu > > do you mean you submitted the patch and i didnt apply it or had to > revert it? It never touched upstream so it must have been reverted due > to some build failure or similar thing. like: In file included from /home/mingo/tip/arch/x86/include/asm/i387.h:16, from /home/mingo/tip/arch/x86/include/asm/suspend_32.h:10, from /home/mingo/tip/arch/x86/include/asm/suspend.h:2, from include/linux/suspend.h:5, from arch/x86/kernel/asm-offsets_32.c:11, from arch/x86/kernel/asm-offsets.c:2: include/linux/hardirq.h:41:27: error: ':' without preceding '?' In file included from arch/x86/kernel/asm-offsets_32.c:24, from arch/x86/kernel/asm-offsets.c:2: include/linux/lguest.h:60:1: error: unterminated argument list invoking macro "BITS_TO_LONGS" In file included from arch/x86/kernel/asm-offsets_32.c:25, from arch/x86/kernel/asm-offsets.c:2: arch/x86/kernel/../../../drivers/lguest/lg.h:236:1: error: unterminated argument list invoking macro "BITS_TO_LONGS" so i've reverted it again. config attached. Ingo