From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Pavel Machek <pavel@suse.cz>
Cc: kernel list <linux-kernel@vger.kernel.org>, rpurdie@rpsys.net
Subject: Re: introduce delayed-leds.h to reduce code duplication
Date: Mon, 12 Jan 2009 08:05:01 -0200 [thread overview]
Message-ID: <20090112100500.GA31656@khazad-dum.debian.net> (raw)
In-Reply-To: <20090111224331.GA28010@elf.ucw.cz>
On Sun, 11 Jan 2009, Pavel Machek wrote:
> What about something like this?
>
> [Alternatively, I can add a flag to the leds class, and make delayed
> leds a built-in functionality...]
>
> [Attached is driver that uses new infrastructure for hp_accel, but it
> does a bit more.]
FWIW, I am looking over the thinkpad-acpi side of this. I like the idea,
but I am not completely sure I agree fully with the changes to
thinkpad-acpi.
Which isn't a problem, as long as the thinkpad-acpi hunks are NOT merged to
any tree before my ACK, please. I will test and comment on the patch before
the weekend.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2009-01-12 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-11 22:43 Pavel Machek
2009-01-12 10:05 ` Henrique de Moraes Holschuh [this message]
2009-01-19 15:02 ` Pavel Machek
2009-01-20 12:04 ` Henrique de Moraes Holschuh
2009-01-21 16:54 ` Richard Purdie
2009-03-08 8:29 ` Pavel Machek
2009-03-11 1:39 ` Henrique de Moraes Holschuh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090112100500.GA31656@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®