From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756264AbZALSvs (ORCPT ); Mon, 12 Jan 2009 13:51:48 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754127AbZALSv2 (ORCPT ); Mon, 12 Jan 2009 13:51:28 -0500 Received: from adelie.canonical.com ([91.189.90.139]:44406 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753995AbZALSv1 (ORCPT ); Mon, 12 Jan 2009 13:51:27 -0500 Date: Mon, 12 Jan 2009 18:51:14 +0000 From: Andy Whitcroft To: Steven Rostedt Cc: LKML , Ingo Molnar , Andrew Morton Subject: Re: checkpatch warning of struct indentation Message-ID: <20090112185114.GB13925@shadowen.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 12, 2009 at 12:57:23PM -0500, Steven Rostedt wrote: > > Hi, > > I'm now seeing the following warnings from checkpatch: > > #325: FILE: kernel/trace/trace_stat.c:21: > + void *stat; > > ERROR: "foo *bar" should be "foo *bar" > #334: FILE: kernel/trace/trace_stat.c:27: > + struct tracer_stat *ts; > > ERROR: "foo *bar" should be "foo *bar" > #337: FILE: kernel/trace/trace_stat.c:30: > + struct dentry *file; Yes those are bogus. They should be fixed in the latest push to akpm. You can check that with this version: http://www.kernel.org/pub/linux/kernel/people/apw/checkpatch/checkpatch.pl-testing -apw