mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Mike Travis <travis@sgi.com>
Cc: Christophe Saout <christophe@saout.de>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH]: xen: fix too early kmalloc call
Date: Mon, 12 Jan 2009 20:13:32 +0100	[thread overview]
Message-ID: <20090112191332.GC15494@elte.hu> (raw)
In-Reply-To: <496B89F4.7080406@sgi.com>


* Mike Travis <travis@sgi.com> wrote:

> > i've applied the fix to tip/cpus4096, in the form below.
> > 
> > Please submit clean log messages. Your commit description was confused 
> > - the patch is From: Christophe, but the message talks about 
> > Christophe in the third person. Also, it included conversational bits 
> > that have no value for the Git history.
> > 
> > 	Ingo
> 
> Ahh, ok, will do.  I wasn't sure how many "liberties" we can take in 
> submitting/changing something from someone else.

You are free to perfect anyone's commit log in essence - i do it for 90% 
of all commits that go via -tip. I fix tyops and grammar mistaiks in every 
second commit, and have to fix basic formatting, structure, explanations 
and reported-by credits and tags in most of them. Submitting patches with 
a well-structured commit log gives you extra credit :-)

[ Obviously you are not free to make a commit log worse and then make it 
  appear as if the guy who submitted it did it ;-) ]

	Ingo

      reply	other threads:[~2009-01-12 19:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-11 19:46 Mike Travis
2009-01-12  8:53 ` Ingo Molnar
2009-01-12 14:42   ` Johannes Weiner
2009-01-12 14:46     ` Ingo Molnar
2009-01-12 18:22     ` Mike Travis
2009-01-12 19:23       ` Christophe Saout
2009-01-12 18:20   ` Mike Travis
2009-01-12 19:13     ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090112191332.GC15494@elte.hu \
    --to=mingo@elte.hu \
    --cc=christophe@saout.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=travis@sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome